Bug 2078805

Summary: [libvirt] untranslated strings in Cockpit - libvirt - zh-CN
Product: Red Hat Enterprise Linux 9 Reporter: Ludek Janda <ljanda>
Component: libvirtAssignee: Ludek Janda <ljanda>
libvirt sub component: General QA Contact: Twinkle <tpardesh>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: medium CC: bbarve, jdenemar, jsuchane, jwboyer, ljanda, lmen, mprivozn, pkrempa, virt-maint
Version: 9.1Keywords: Reopened, Translation, Triaged, Upstream
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-8.7.0-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-09 07:26:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 8.7.0
Embargoed:

Description Ludek Janda 2022-04-26 09:32:05 UTC
Created attachment 1875030 [details]
screenshots from QA

Description of problem:

We found untranslated strings during RHEL 9.0 localization QA in Cockpit. According to mmarusak these strings come from libvirt.  

Tested in zh-CN

"storage volume 'tl' exists already"

"operation failed: Storage source conflict with pool: 'test'"

Version-Release number of selected component (if applicable):
RHEL 9.0


Our team can provide translation, we just need access to language PO files.

Comment 1 Peter Krempa 2022-04-26 09:41:07 UTC
Libvirt's translation are hanlded via fedora weblate:

https://translate.fedoraproject.org/projects/libvirt/libvirt/

Comment 3 Jaroslav Suchanek 2022-04-27 08:26:17 UTC
I guess, this will be pulled in with the next rebase.

Comment 4 Michal Privoznik 2022-05-04 07:19:53 UTC
And indeed it was: https://gitlab.com/libvirt/libvirt/-/commit/413bf1ed540999c537729fdfebfd75826c22fc0f

Comment 5 Ján Tomko 2022-05-04 11:20:34 UTC
That commit updated the orignal strings; there are no new translations for zh_CN in it.

Also, the "Storage source conflict with pool" message was translated even back in 2018:

commit 7a8a84ecd18e3d594c6ab2cbf86815849eb652ed
CommitDate: 2018-04-19 11:19:37 +0100

    po: minimize language zh_CN

https://gitlab.com/libvirt/libvirt/-/blob/7a8a84ecd18e3d594c6ab2cbf86815849eb652ed/po/zh_CN.mini.po#L9417

Perhaps libvirt was not told to use the locale?

Comment 7 Jiri Denemark 2022-08-04 13:03:51 UTC
We are past the final rebase for libvirt 9.1.0 and pulled the latest
translation files from weblate. However, I don't see any new translations for
Chinese. In 2022 I only see updated translations for Swedish, Korean,
Ukrainian, Finish and a little bit of Polish, Russian, Georgian, German, and
Japanese. And that's it. So either the required translations were already
present in libvirt before and/or there's actually no real desire to translate
more strings (this is most likely as the last translation update for Chinese
was done in February 2021).

And both strings are already translated (even though marked as fuzzy) so I
guess despite cockpit being set to use Chinese locale the libvirt daemon which
cockpit is talking to was using English.

Either way I'm closing this BZ as there's nothing we can do about it.

Comment 14 Jiri Denemark 2022-08-30 12:27:21 UTC
This is already pushed upstream and will be included in the 8.7.0 release planned for Sep 1.

Comment 15 Twinkle 2022-09-26 10:54:38 UTC
Seems like some strings are still displayed in English, may be due to some libvirtd issue. Can see translated strings here: https://translate.fedoraproject.org/projects/libvirt/libvirt/
Hence, marking the bug as verified- tested. Will open a bug if some non-translated strings found. Thanks.

Comment 18 Twinkle 2022-09-26 11:42:37 UTC
I will file a new bug for libvirt translation issue. Thanks!!

Comment 21 errata-xmlrpc 2023-05-09 07:26:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libvirt bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2171