Bug 2078983

Summary: Tabbable latest version 5.3.1 is not compatible with jest dom/ JSDom without changes to PF4.
Product: Red Hat Satellite Reporter: Samir Jha <sajha>
Component: ProvisioningAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: Akhil Jha <akjha>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.11.0CC: inecas, pcreech, sshtein
Target Milestone: 6.11.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-05 14:35:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Samir Jha 2022-04-26 16:02:48 UTC
From my debugging and googling, the latest version of Tabbable that is 5.3.0 (and onwards) needs some changes to the Modal/Wizard components in Patternfly4 to be able to support tests.

Specifically this: https://github.com/focus-trap/tabbable#testing-in-jsdom

Modal currently has the prop disableFocusTrap that can be set to false and that lets us work around the issue without ever activating the trap. I spoke to folks on PF4 slack and they lock the version of FocusTrap but Focustrap brings in the latest 5.x.x tabbable causing the test failures.

There's an open PF4 issue around this: https://github.com/patternfly/patternfly-react/issues/7288

Comment 1 Samir Jha 2022-04-26 16:02:52 UTC
Created from redmine issue https://projects.theforeman.org/issues/34802

Comment 2 Samir Jha 2022-04-26 16:02:54 UTC
Upstream bug assigned to None

Comment 3 Samir Jha 2022-04-26 16:06:13 UTC
This will need to be cherry-picked to 6.11 to resolve the pipeline errors seen here: https://master-jenkins-csb-satellite-delivery.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/sat6-unit-test-katello/detail/sat6-unit-test-katello/722/pipeline

Comment 4 Bryan Kearney 2022-04-26 20:05:12 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/34802 has been resolved.

Comment 9 errata-xmlrpc 2022-07-05 14:35:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.11 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.