Bug 2079125

Summary: asus-nb-wmi Module failed to probe causes multimedia keys unusable.
Product: [Fedora] Fedora Reporter: Ahmad Raniri <lidgnulinux>
Component: kernelAssignee: Kernel Maintainer List <kernel-maint>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 36CC: acaringi, adscvr, airlied, alciregi, bskeggs, hdegoede, hpa, jarodwilson, jglisse, jonathan, josef, kernel-maint, lgoncalv, linville, masami256, mchehab, ptalbert, steved
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-28 13:01:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
journalctl output. none

Description Ahmad Raniri 2022-04-27 02:59:55 UTC 
Created attachment 1875242 [details]
journalctl output.

1. Please describe the problem:

Asus-nb-wmi failed to probe, it causes multimedia keys (fn+F10/F11/F12) become unusable, previous kernel / 5.16 works fine and asus-nb-wmi is loaded succesfully. When I try to moprobe and insmod, I get `modprobe: ERROR: could not insert 'asus_nb_wmi': No such device`, the module is exist.


2. What is the Version-Release number of the kernel:

kernel : 5.17.3-302.fc36.x86_64.


3. Did it work previously in Fedora? If so, what kernel version did the issue
   *first* appear?  Old kernels are available for download at
   https://koji.fedoraproject.org/koji/packageinfo?packageID=8 :

Kernel 5.16 works fine, it begins with 5.17.3-302.fc36.x86_64 version.


4. Can you reproduce this issue? If so, please provide the steps to reproduce
   the issue below:

Yes, I can. 
- Boot up the 5.17.3-302.fc36.x86_64 kernel.
- Login to DE and wayland compositors
- Open pavucontrol.
- Press multimedia keys / fn+F10/F11/F12 to toggle mute, set volume down/up, nothing happens
- Reboot to 5.16 kernel.
- Login to DE and wayland compositors.
- Open pavucontrol.
- Press multimedia keys / fn+F10/F11/F12 to toggle mute, set volume down/up, it works.

5. Does this problem occur with the latest Rawhide kernel? To install the
   Rawhide kernel, run ``sudo dnf install fedora-repos-rawhide`` followed by
   ``sudo dnf update --enablerepo=rawhide kernel``:

- No, I don't even try rawhide.


6. Are you running any modules that not shipped with directly Fedora's kernel?:

No I'm not.


7. Please attach the kernel logs. You can get the complete kernel log
   for a boot with ``journalctl --no-hostname -k > dmesg.txt``. If the
   issue occurred on a previous boot, use the journalctl ``-b`` flag.
Comment 1 Hans de Goede 2022-04-27 11:53:14 UTC 
Thank you for reporting this.

I believe that I know what is causing this and I've written a fix for this:
https://lore.kernel.org/platform-driver-x86/20220427114956.332919-1-hdegoede@redhat.com/

I've started a test build of a Fedora kernel with the fix for this added:
https://koji.fedoraproject.org/koji/taskinfo?taskID=86301951

Note this is still building atm (this may take a couple of hours). Once this is done building please give this version a try and let me know if it fixes things. Once I've confirmation that this fixes things, then I'll send this on its way to the mainline kernel asap, so that the fix can get included in the official Fedora kernel builds through the stable tree.

See here for some generic instructions for installing a kernel directly from koji (Fedora's buildsystem):
https://fedorapeople.org/~jwrdegoede/kernel-test-instructions.txt
Comment 2 Ahmad Raniri 2022-04-27 13:10:08 UTC 
Thanks, I'll try it soon.
Comment 3 Hans de Goede 2022-04-27 13:32:52 UTC 
Note the build is done now, please download the test kernel, give it a try and let me know if it fixes things.
Comment 4 Ahmad Raniri 2022-04-27 15:57:06 UTC 
Thanks, Here a short review (it's almost midnight here, btw)

- The test kernel works.
It boots succesfully.
 
- asus-nb-wmi module is loaded.
I check with `lsmod | grep wmi` and the module is listed and loaded.

- Multimedia keys work.
I enter GNOME and press multimedia keys and I can set volume up/down and toggle mute with them.
Comment 5 Hans de Goede 2022-04-28 13:01:08 UTC 
(In reply to Ahmad Raniri from comment #4)
> Thanks, Here a short review (it's almost midnight here, btw)
> 
> - The test kernel works.
> It boots succesfully.
>  
> - asus-nb-wmi module is loaded.
> I check with `lsmod | grep wmi` and the module is listed and loaded.
> 
> - Multimedia keys work.
> I enter GNOME and press multimedia keys and I can set volume up/down and
> toggle mute with them.

Thank you for the quick test. I've submitted the fix to the for Linus (together with a bunch of other fixes):
https://lore.kernel.org/platform-driver-x86/d6954974-3ee8-9573-f906-c141165cd4b7@redhat.com/

Once Linus merges this Greg should cherry-pick it into the 5.17.y releases soonish.