Bug 2079289

Summary:	Review Request: rust-clap_lex - Minimal, flexible command line parser
Product:	[Fedora] Fedora	Reporter:	Carmelo Sarta <carmelo.sarta.main>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-11 07:38:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Carmelo Sarta 2022-04-27 10:35:15 UTC

Spec URL: https://raw.githubusercontent.com/Laiot/rust-clap_lex-rpm/master/rust-clap_lex.spec
SRPM URL: https://github.com/Laiot/rust-clap_lex-rpm/raw/master/rust-clap_lex-0.2.0-1.fc36.src.rpm
Description: Minimal, flexible command line parser
Fedora Account System Username: laiot

Comment 1 Fabio Valentini 2022-05-01 14:41:01 UTC

The upstream project project has released 0.2.0 of this crate.
Would it be possible to update it for your package, or do you specifically need 0.1.x?

Comment 2 Carmelo Sarta 2022-05-01 15:26:12 UTC

Thank you Fabio for the review, I updated the srpm link in the previous comment.

Comment 3 Fabio Valentini 2022-05-04 10:02:39 UTC

Thanks for the update! Looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Gwyn Ciesla 2022-05-05 14:13:37 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clap_lex