Bug 2080909

Summary:	The satellite-maintain self-upgrade does not disable the non RHSM repository if it was not enabled on system
Product:	Red Hat Satellite	Reporter:	Amit Upadhye <aupadhye>
Component:	Satellite Maintain	Assignee:	Amit Upadhye <aupadhye>
Status:	CLOSED ERRATA	QA Contact:	Gaurav Talreja <gtalreja>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.11.0	CC:	apatel, kgaikwad, pcreech
Target Milestone:	6.11.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rubygem-foreman_maintain-1.0.10	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-05 14:35:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2026415

Description Amit Upadhye 2022-05-02 10:29:09 UTC

Description of problem:

The satellite-maintain provides a self-upgrade command which accepts custom repository label. This repository can be used to update foreman-maintain and satellite-maintain packages from non RHSM repository in disconnected and test environments.

The custom repository should be disable on completing the package update if it was not enabled on system.

Version-Release number of selected component (if applicable):

Satellite 6.11

How reproducible:

Every time

Steps to Reproduce:
1. Confirm that custom repository is not enabled
2. Run the satellite-maintain command with custom repo label
# satellite-maintain self-upgrade --maintenance-repo-label custom-repo
3. Confirm that custom-repo stays enabled after completion of the run

Actual results:

custom repo stays enabled

Expected results:

custom repo should be disabled if it was not enabled already on system
Additional info:

Comment 1 Amit Upadhye 2022-05-02 10:30:22 UTC

Created redmine issue https://projects.theforeman.org/issues/34854 from this bug

Comment 2 Bryan Kearney 2022-05-11 12:04:54 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/34854 has been resolved.

Comment 3 Amit Upadhye 2022-05-11 12:09:22 UTC

We need to get 1.0.10 version with cherry picks : https://github.com/theforeman/foreman-packaging/pull/7887

Comment 4 Gaurav Talreja 2022-05-25 19:48:28 UTC

Verified.

Tested on Satellite 6.11.0 Snap 21.0
Version: rubygem-foreman_maintain-1.0.10-1.el7sat.noarch

Steps:
1. Add custom repo (label: sat-maintain) with `enabled=0` for new maintenance repository.
2. # foreman-maintain self-upgrade --maintenance-repo-label sat-maintain
3. Update `s/enabled=0/enabled=1` in custom repo of new maintenance repository.
4. # foreman-maintain self-upgrade --maintenance-repo-label sat-maintain

Observations:
After executing a self-upgrade, the custom repo is disabled if it was previously disabled, and enabled if it had previously been enabled on the system.

Comment 7 errata-xmlrpc 2022-07-05 14:35:13 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.11 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5498