Bug 2081343

Summary: CentOS 7 DataImportCron naming does not match existing usage
Product: Container Native Virtualization (CNV) Reporter: Sarah Bennert <sbennert>
Component: InstallationAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED WONTFIX QA Contact: Natalie Gavrielov <ngavrilo>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.10.1CC: cnv-qe-bugs, dholler, nunnatsa, stirabos
Target Milestone: ---Flags: sbennert: needinfo-
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-09 14:44:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sarah Bennert 2022-05-03 13:38:40 UTC 
Description of problem:

centos-7-image-cron was expected to be centos7-image-cron to match existing naming against datasources


How reproducible:
100%

Steps to Reproduce:
1. $ oc get dataimportcron -n openshift-virtualization-os-images

Actual results:

centos-7-image-cron

Expected results:

centos7-image-cron

Additional info:

$ oc get datasources -n openshift-virtualization-os-images
NAME             AGE
centos-stream8   4d15h
centos-stream9   4d22h
centos7          4d22h
fedora           4d22h
rhel6            4d22h
rhel7            4d22h
rhel8            4d22h
rhel9            4d22h
win10            4d22h
win2k12r2        4d22h
win2k16          4d22h
win2k19          4d22h

$ oc get dataimportcron -n openshift-virtualization-os-images
NAME                        AGE
centos-7-image-cron         4d15h
centos-stream8-image-cron   4d15h
centos-stream9-image-cron   4d15h
fedora-image-cron           4d15h
rhel8-image-cron            4d15h
rhel9-image-cron            4d15h
Comment 2 Nahshon Unna-Tsameret 2022-05-08 07:08:18 UTC 
@sbennert - I don't think it's a blocker. We can rename the DIC and it should create a new one *instead of* the existing one. Since the managedDataSource is the same, it should work with no problems. The only issue is that the old DVs won't be garbage collected, because they'll have the old DIC annotation.

For that reason, I'm not sure we should fix the DIC for wrong name, because the outcome is worse. @
Comment 3 Nahshon Unna-Tsameret 2022-05-08 07:08:59 UTC 
@
Comment 4 Nahshon Unna-Tsameret 2022-05-08 07:10:03 UTC 
@stirabos - WDYT?
Comment 5 Simone Tiraboschi 2022-05-09 14:44:32 UTC 
I tend to think that is not such a serious issue, for instance centos-7-image-cron and centos-stream8-image-cron sounds coherents to me and I agree that a fix can be worse than the issue introducing leftovers that need explicit deletion.

Personally I'm for closing this as WONTFIX, please feel free to reopen if you see some other technical aspect that I'm missing.