Bug 2081831

Summary: [RFE] Improve disk hotplug UX
Product: Container Native Virtualization (CNV) Reporter: Adam Litke <alitke>
Component: User ExperienceAssignee: Aviv Turgeman <aturgema>
Status: CLOSED ERRATA QA Contact: Guohua Ouyang <gouyang>
Severity: low Docs Contact:
Priority: medium    
Version: 4.10.0CC: cnv-qe-bugs, gouyang, yzamir
Target Milestone: ---   
Target Release: 4.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-09-14 19:31:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Add disk dialog
none
Delete should be Detach
none
Delete should be unchecked by default none

Description Adam Litke 2022-05-04 18:42:13 UTC 
Description of problem:  Upon review of the UI flows around disk hotplug and in light of additional development of backend functionality I would like to request the following enhancements to the user interface which should make the UI easier to understand and the feature easier to consume:

1. In the "Add Disk" dialog, remove the `detach disk upon VM restart' checkbox completely and have the default be that a VM restart will re-hotplug the disk.  If the user would like the disk to be detached from the VM, she should perform an explicit action to do so.

2. In the VM disks kebab menu, rename 'Delete' to 'Detach' since this more accurately describes what is happening.

3. In the "Detach disk" confirmation dialog, the option to delete the disk should be unchecked by default.  This will result in the less destructive option being the default path and this more accurately represents what a 'detach' operation should be by default.

Additional info:  Please see attached screenshots for more context.
Comment 1 Adam Litke 2022-05-04 18:45:29 UTC 
Created attachment 1877141 [details]
Add disk dialog
Comment 3 Adam Litke 2022-05-04 18:47:19 UTC 
Created attachment 1877143 [details]
Delete should be unchecked by default
Comment 4 Guohua Ouyang 2022-05-26 06:39:42 UTC 
verified on v4.11.0-403(OCP v4.11.0-32)
Comment 7 errata-xmlrpc 2022-09-14 19:31:44 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.11.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:6526