Bug 2082036
| Summary: | Review Request: obserware - An advanced system monitor utility written in Python and Qt | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Akashdeep Dhar <akashdeep.dhar> |
| Component: | obserware | Assignee: | Akashdeep Dhar <akashdeep.dhar> |
| Status: | CLOSED ERRATA | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | akashdeep.dhar, package-review, thunderbirdtr |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | obserware-0.2.9-1.fc36 obserware-0.2.9-1.fc35 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-25 01:04:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Akashdeep Dhar
2022-05-05 09:27:39 UTC
I'm taking this review First please change your SOURCE0 into pypi macro (Source0: %{pypi_source})
Start your Release: 0%{?dist} number "1" and fix your dates in your change log along with your "release versions" as well.
Also please remove those as well.
ExclusiveArch: x86_64
%global debug_package %{nil}
I addressed your suggestions in the following RPM specfile and source RPM. Spec URL: https://gitlab.com/t0xic0der/obserware/uploads/2e848e41d0e7aed8e5820615070349ac/obserware.spec SRPM URL: https://gitlab.com/t0xic0der/obserware/uploads/4b556e02d18e9ff922b2db1749eb0e0c/obserware-0.2.9-1.fc36.src.rpm The support for architectures like arm, arm64, ppc, ppc64, ppc64le, s390x etc. is not planned and the application does not work there. Only x86 and x86_64 architectures are supported. Please do take a look and let me know if any more changes are needed. - Please remove exclude arch section - add check section and remove app stream data check from install section - Add desktop utils as BR for check section - remove no debug nil global variable as well Here's a new set of RPM specfile and source RPM. Spec URL: https://gitlab.com/t0xic0der/obserware/uploads/6ccef73fb855a5fcda8e063758730b4c/obserware.spec SRPM URL: https://gitlab.com/t0xic0der/obserware/uploads/f4312871e3714069572405ba20147bb5/obserware-0.2.9-1.fc36.src.rpm All looks LGTM to me so Package Approved (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/obserware FEDORA-2022-ebe881da2a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ebe881da2a FEDORA-2022-84bf91b9d9 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-84bf91b9d9 FEDORA-2022-ebe881da2a has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-84bf91b9d9 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. |