Bug 2082662
| Summary: | Review Request: liblerc - Limited Error Raster Compression | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sandro Mani <manisandro> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-05-20 21:55:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sandro Mani
2022-05-06 16:49:46 UTC
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=86734525 > Version: 3.1 > Release: 0.1%{?commit:.git%{shortcommit}}%{?dist} Version: 3.1.0%{?commit:.git%{shortcommit}}%{?dist} Release: 1 [https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots] > Summary: Limited Error Raster Compression Maybe "Library for …" ? As usual, I'd suggest %autorelease and %autochangelog. It seems that the algorithm is patented and that the Authors provide a grant via para 4 of the license. This appears to be OK. Our guidelines say: > If a package contains code covered by known patents, then you should seek a written patent grant > (and include that grant inside the package) before submitting it for Fedora. rpmlint: liblerc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/liblerc/NOTICE liblerc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/liblerc/README.md liblerc-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/liblerc-devel/MORE.md liblerc-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libLerc.so.3-3.1-0.1.gitb1de4cd.fc37.x86_64.debug liblerc-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/libLerc.so.3-3.1-0.1.gitb1de4cd.fc37.x86_64.debug mingw32-liblerc.noarch: W: no-documentation mingw64-liblerc.noarch: W: no-documentation mingw32-liblerc.noarch: E: double-slash-in-pkgconfig-path /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/Lerc.pc libdir=${exec_prefix}//usr/i686-w64-mingw32/sys-root/mingw/lib mingw64-liblerc.noarch: E: double-slash-in-pkgconfig-path /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/Lerc.pc libdir=${exec_prefix}//usr/x86_64-w64-mingw32/sys-root/mingw/lib mingw32-liblerc.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/Lerc_c_api.h mingw32-liblerc.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/Lerc_types.h mingw32-liblerc.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libLerc.dll.a mingw32-liblerc.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/Lerc.pc mingw64-liblerc.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/Lerc_c_api.h mingw64-liblerc.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/Lerc_types.h mingw64-liblerc.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libLerc.dll.a mingw64-liblerc.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/Lerc.pc liblerc-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/01/a0882a6471b6332eeab6fe8aed3de0cbea741b ../../../.build-id/01/a0882a6471b6332eeab6fe8aed3de0cbea741b mingw32-liblerc.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libLerc.dll.a mingw64-liblerc.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libLerc.dll.a Seems all bogus or unimportant. fedora-review also doesn't find anything interesting. + package name is OK + latest version (snapshot) + license is acceptable for Fedora (ASL 2.0) + license is specified correctly + builds and installs + BR/P/R look OK Package is APPROVED. Many thanks for the review, let me know if I can review anything in exchange.
> > Version: 3.1
> > Release: 0.1%{?commit:.git%{shortcommit}}%{?dist}
> Version: 3.1.0%{?commit:.git%{shortcommit}}%{?dist}
> Release: 1
I was using the old school syntax here for pre-releases (3.1 is the next expected version, but not yet tagged).
Yes I'll need to look into autochangelog/autorelease.
I'll address the relevant rpmlint issues when importing.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/liblerc |