Bug 2082773

Summary: [AWS-EBS-CSI-driver-Operator] Generic ephemeral volumes online resize Filesystem type volume stucked at file system resize phase
Product: OpenShift Container Platform Reporter: Penghao Wang <pewang>
Component: StorageAssignee: Hemant Kumar <hekumar>
Storage sub component: Operators QA Contact: Penghao Wang <pewang>
Status: CLOSED ERRATA Docs Contact: Olivia Payne <opayne>
Severity: medium    
Priority: unspecified CC: hekumar, jsafrane, opayne
Version: 4.11Flags: pewang: needinfo-
Target Milestone: ---   
Target Release: 4.12.0   
Hardware: All   
OS: All   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
* Previously, checks for generic ephemeral volumes failed. With this update, checks for expandable volumes now include generic ephemeral volumes. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2082773[*BZ#2082773*]
Story Points: ---
Clone Of:
: 2104344 (view as bug list) Environment:
Last Closed: 2023-01-17 19:48:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 2104344    

Comment 3 Hemant Kumar 2022-05-11 02:32:08 UTC
I think this is happening because we are explicily checking for pvc sources in pod's volume:

	if podVolume.PersistentVolumeClaim == nil || pvc == nil {
		// Only PVC supports resize operation.

And since this returns false - resize operation is not attempted.

Comment 5 Hemant Kumar 2022-05-11 19:08:36 UTC
Yeah I don't think you are supposed to modify the workloads directly. 

I opened https://github.com/kubernetes/kubernetes/pull/109987 to fix the issue and verified that it works.

Comment 6 Penghao Wang 2022-05-11 23:18:40 UTC
Got it. Many thanks for the fix and clarify!

Comment 7 Hemant Kumar 2022-05-18 20:17:02 UTC
I have backported the fixes to 1.24 and 1.23 - https://github.com/kubernetes/kubernetes/pull/110117 and https://github.com/kubernetes/kubernetes/pull/110118

I will keep an eye on them getting merged and once they merge I will probably link this to a bug that does rebase.

Comment 8 Penghao Wang 2022-05-19 01:04:06 UTC
Sure. Thanks!

Comment 9 Hemant Kumar 2022-06-22 16:00:39 UTC
backport for OCP - https://github.com/openshift/kubernetes/pull/1296

Comment 18 errata-xmlrpc 2023-01-17 19:48:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.12.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.