Bug 2082857

Summary: "Warning! Unable to generate a proper UUID!" when built against libuuid 2.38
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: gdiskAssignee: Terje Røsten <terje.rosten>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: terje.rosten
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gdisk-1.0.9-2.fc36 gdisk-1.0.9-2.fc35 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-11 01:19:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dominik 'Rathann' Mierzejewski 2022-05-07 23:34:34 UTC
Description of problem:
gdisk 1.0.9 displays the following warning when opening an MBR-only storage device:

Warning! Unable to generate a proper UUID! Creating an improper one as a last
resort! Windows 7 may crash if you save this partition table!

Version-Release number of selected component (if applicable):
1.0.9-1.fc36

How reproducible:
Always

Steps to Reproduce:
1. attach an MBR-only storage device (e.g. sdc)
2. gdisk /dev/sdc

Actual results:
Warning! Unable to generate a proper UUID! Creating an improper one as a last
resort! Windows 7 may crash if you save this partition table!

Expected results:
No warning.

Additional info:
Downgrading to 1.0.8-3.fc36 helps.

This seems to be the issue reported at https://sourceforge.net/p/gptfdisk/mailman/message/37640877/ and fixed in https://sourceforge.net/p/gptfdisk/code/ci/5d5e76d369a412bfb3d2cebb5fc0a7509cef878d/ .

You can also see this warning when running the internal testsuite (chmod+x gdisk_test.sh && make test). Please add it in %check, by the way.

Comment 1 Dominik 'Rathann' Mierzejewski 2022-05-08 00:00:39 UTC
Oddly enough, applying the above upstream patch doesn't fix the warning for sgdisk in the testsuite, and Fedora popt doesn't contain the change mentioned in the bug report above, so I don't fully understand what's going on here.

Comment 2 Dominik 'Rathann' Mierzejewski 2022-05-08 00:17:21 UTC
Sorry, I confused two issues.

We're not affected by the popt issue yet (but will be once a release with the change mentioned above makes it into a popt release in Fedora, so it's a good idea to run the testsuite in %check to catch it).

This one is related to libuuid and the fix for it is actually here:
https://sourceforge.net/p/gptfdisk/code/ci/6a8416cbd12d55f882bb751993b94f72d338d96f/

I can confirm that building gdisk with this patch applied fixes the warnings in both the testsuite and in my test case.

Comment 3 Dominik 'Rathann' Mierzejewski 2022-05-08 00:20:13 UTC
Downgrading to 1.0.8-3.fc36 helps, because it was built against libuuid-2.37.2-1.fc36. 1.0.9-1.fc36 was built against libuuid-2.38-0.2.fc36, for which gdisk needs the upstream patch from comment #2.

Comment 4 Dominik 'Rathann' Mierzejewski 2022-05-08 00:44:43 UTC
https://src.fedoraproject.org/rpms/gdisk/pull-request/1 opened to fix this.

Comment 5 Fedora Update System 2022-05-08 19:00:37 UTC
FEDORA-2022-c086fb92ed has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c086fb92ed

Comment 6 Fedora Update System 2022-05-08 19:00:40 UTC
FEDORA-2022-79bdaa4fbc has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-79bdaa4fbc

Comment 7 Fedora Update System 2022-05-09 02:05:09 UTC
FEDORA-2022-79bdaa4fbc has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-79bdaa4fbc`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-79bdaa4fbc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-05-09 02:55:07 UTC
FEDORA-2022-c086fb92ed has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-c086fb92ed`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c086fb92ed

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-05-11 01:19:41 UTC
FEDORA-2022-c086fb92ed has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-05-24 02:43:47 UTC
FEDORA-2022-79bdaa4fbc has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.