Bug 2083666

Summary: [RHOSP 17.0] rsyslog uses old puppet-tripleo code resulting overcloud deployment failure
Product: Red Hat OpenStack Reporter: Leonid Natapov <lnatapov>
Component: puppet-rsyslogAssignee: Martin Magr <mmagr>
Status: CLOSED ERRATA QA Contact: Leonid Natapov <lnatapov>
Severity: urgent Docs Contact: Joanne O'Flynn <joflynn>
Priority: urgent    
Version: 17.0 (Wallaby)CC: csibbitt, jjoyce, jschluet, lmadsen, slinaber, tkajinam, tvignaud
Target Milestone: betaKeywords: Regression, Triaged
Target Release: 17.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: puppet-rsyslog-4.0.1-0.20220705180451.2548a0d.el9ost Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-09-21 12:21:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2066951, 2083858    

Description Leonid Natapov 2022-05-10 14:51:52 UTC
OSP17 | rsyslog uses old puppet-tripleo code therefor overcloud deployment with rsyslog fails.

---------

2022-05-10 14:25:28.041583 | 5254008e-5b23-b758-80be-000000008412 |      FATAL | Create containers managed by Podman for /var/lib/tripleo-config/container-puppet-config/step_1 | controller-1 | error={"changed": false, "msg": "Failed containers: container-puppet-rsyslog"}
2022-05-10 14:25:28.042834 | 5254008e-5b23-b758-80be-000000008412 |     TIMING | tripleo_container_manage : Create containers managed by Podman for /var/lib/tripleo-config/container-puppet-config/step_1 | controller-1 | 0:12:15.356465 | 60.32s
2022-05-10 14:25:37.234515 |                                      |    WARNING | ERROR: Can't run container container-puppet-rsyslog
stderr: + /usr/bin/puppet apply --summarize --detailed-exitcodes --color=false --modulepath=/etc/puppet/modules:/usr/share/openstack-puppet/modules --tags '"file,file_line,concat,augeas,cron,rsyslog::generate_concat,concat::fragment"' /etc/config.pp
+ logger -s -t puppet-user
<13>May 10 14:25:30 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
<13>May 10 14:25:37 puppet-user:    (file: /etc/puppet/hiera.yaml)
<13>May 10 14:25:37 puppet-user: Warning: Undefined variable '::deploy_config_name'; 
<13>May 10 14:25:37 puppet-user:    (file & line not available)
<13>May 10 14:25:37 puppet-user: Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/7.10/deprecated_language.html
<13>May 10 14:25:37 puppet-user:    (file & line not available)
<13>May 10 14:25:37 puppet-user: Error: Evaluation Error: Error while evaluating a Resource Statement, Could not find declared class rsyslog::server (file: /etc/puppet/modules/tripleo/manifests/profile/base/logging/rsyslog.pp, line: 149, column: 5) on node controller-0.redhat.local
+ rc=1
+ '[' false = false ']'
+ set +x
2022-05-10 14:25:37.235460 | 5254008e-5b23-b758-80be-000000008598 |      FATAL | Create containers managed by Podman for /var/lib/tripleo-config/container-puppet-config/step_1 | controller-0 | error={"changed": false, "msg": "Failed containers: container-puppet-rsyslog"}

Comment 9 Martin Magr 2022-06-20 19:55:26 UTC
There's no rsyslog::server puppet class any more. Apparently the version pin which we had in osp16 was removed and puppet-rsyslog update was pulled in. We need to switch in puppet-tripleo to use rsyslog::config instead.


[1] https://github.com/voxpupuli/puppet-rsyslog/tree/master/manifests

Comment 10 Takashi Kajinami 2022-07-04 16:49:37 UTC
The pin was removed AFTER wallaby release and it has never been backport to wallaby.
Looking at the latest compose we still have puppet-rsyslog-4.0.1 which provides the rsyslog::server class.

So I believe we don't need any change in RHOSP17 unless there is a need to bump puppet-rsyslog version.

Comment 19 Leonid Natapov 2022-07-18 06:34:37 UTC
Fixed. overcloud successfully deployed with enabled rsyslog. rsyslog container is up and running

Comment 23 errata-xmlrpc 2022-09-21 12:21:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 17.0 (Wallaby)), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:6543