Bug 208396

I really don't think that this package should be blocker for uvcvideo and gspca
kmod packages. 
I already added gspca kmod package for its review. Users can download kernel
module source from respective websites and they can use this package happily. I
am using this since last 2 weeks without any problem with both kernel modules
installed from RPMS i made from their sources(gspca rpms are already submitted
for review).

So anyone can review this package and also if anyone have any webcam supported
from any of the kernel modules, they can test it happily.

I'll do the review - I can't review the functionality, though, since I'm webcamless.

Thanks. Feel free to ask me anything about this package usage. Even you can test
its some functionality without webcam. You just need to fill USB IDs of any webcam
say for 
Logitech Quickcam Image Vendor ID 046d Product ID 08a7 
and you will get information about whether its supported by uvcvideo or gspca
drivers or not.

Need fixing:
- rpmlint on SRPM:
W: v4l2-tool mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 1)

- v4l2-tool.png included twice (in /usr/share/pixmaps and
/usr/share/pixmaps/v4l2-tool). I think one of them is meant to be
v4l2-tool-logo.png, which is not packaged

- dl.sourceforge.net has been refusing connections for some time. Change URL to
use one of the download mirrors?

- License file (COPYING) needs to be included in %docs
- %description incorrect (says it's digiKam-doc)
- desktop file's Categories should probably include HardwareSettings (and
perhaps Utility) and should not include Player. Not sure if the Audio category
is necessary - I think of a webcam as primarily a video device.


Good:
- Source matches upstream
- License OK
- Spec readable, language OK

The Icon= line in the desktop file does not need to specify an extension, by the
way. Most desktop files omit this (perhaps to make a switch to SVG easier)

Updated links
Spec URL: http://people.redhat.com/pnemade/v4l2-tool/v4l2-tool.spec
SRPM URL: http://people.redhat.com/pnemade/v4l2-tool/v4l2-tool-1.0.2-2.src.rpm

Created attachment 142599 [details]
Updated spec file

Reformatted the spec file, using Emacs M-x untabify to convert tabs->spaces and
Escape-q to line up the description text.

Changed desktop file to use v4l2-tool-logo.png, it's larger than v4l2-tool.png.
Added back AudioVideo category (see
http://standards.freedesktop.org/menu-spec/latest/apa.html : an application is
either Audio or Video (or both), but must also include AudioVideo)

Oops i did changes but looks like i forgot to upload proper SPEC file but
updated SPEC was included in SRPM. 
Anyway keeping release same -2 and using your changes, i uploaded new SRPM and
SPEC. Kindly review them.
Updated links
Spec URL: http://people.redhat.com/pnemade/v4l2-tool/v4l2-tool.spec
SRPM URL: http://people.redhat.com/pnemade/v4l2-tool/v4l2-tool-1.0.2-2.src.rpm

Everything looks good. I'm a bit hesitant about listing %{_datadir}/* instead of
the specific subdirectories, but rpm -qf /usr/share/ shows that other packages
are doing that as well anyway.

APPROVED

Thanks built for devel only successfully.