Bug 2084538

Summary: Firefox is missing spellchecking dictionaries
Product: [Fedora] Fedora Reporter: Julian Sikorski <belegdol>
Component: firefoxAssignee: Martin Stransky <stransky>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: alex.ploumistos, erack, gecko-bugs-nobody, i18n-bugs, jhorak, kai-engert-fedora, klaas, petersen, pjasicek, pnemade, rhughes, rstrode, sandmann, stransky
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-06-08 17:28:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot of missing dictionaries none

Description Julian Sikorski 2022-05-12 11:57:10 UTC
Created attachment 1878911 [details]
screenshot of missing dictionaries

Description of problem:
Looks like https://bugzilla.redhat.com/show_bug.cgi?id=1627837 is back in some aspect. Even though I have hunspell-de installed, only US english dictionary is showing.

Version-Release number of selected component (if applicable):
firefox-100.0-4.fc36.x86_64

How reproducible:
always

Steps to Reproduce:
1. install firefox on system running a locale other than US English
2. try to spellcheck text

Actual results:
Only US English is available

Expected results:
Multiple variants of German and English are available.

Additional info:
$ rpm -qa | grep hunspell
hunspell-filesystem-1.7.0-19.fc36.x86_64
hunspell-de-20161207-3.fc36.noarch
hunspell-en-GB-0.20140811.1-22.fc36.noarch
hunspell-en-0.20140811.1-22.fc36.noarch
hunspell-en-US-0.20140811.1-22.fc36.noarch
hunspell-1.7.0-19.fc36.x86_64

thunderbird-91.9.0-1.fc36.x86_64 is working as expected.

Comment 1 Julian Sikorski 2022-05-12 12:01:44 UTC
Updating spellchecker.dictionary_path to /usr/share/hunspell fixes the problem. I guess it is a knock-on effect of https://fedoraproject.org/wiki/Changes/Hunspell_dictionary_dir_change.

Comment 2 Martin Stransky 2022-05-12 12:03:37 UTC
Will look at it, Thanks.

Comment 4 Parag Nemade 2022-05-17 01:17:11 UTC
*** Bug 2086929 has been marked as a duplicate of this bug. ***

Comment 5 Parag Nemade 2022-05-17 05:58:42 UTC
The new rawhide update firefox-100.0-6.fc37.x86_64.rpm now fixed this bug.
Thanks to all for helping reporting and fixing this bug.

Comment 6 Jan Horak 2022-05-18 11:16:35 UTC
This should be fixed in 100.0.1 update.

Comment 7 Alexander Ploumistos 2022-05-18 15:01:17 UTC
(In reply to Jan Horak from comment #6)
> This should be fixed in 100.0.1 update.

Just tested, it is.

Comment 8 Martin Stransky 2022-05-18 19:18:02 UTC
That fix causes build failures on F35:

Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/firefox-100.0.1-1.fc35.i386
error: Installed (but unpackaged) file(s) found:
   /usr/lib/firefox/browser/defaults/preferences/firefox-redhat-default-prefs.jse
RPM build errors:
    Duplicate build-ids /builddir/build/BUILDROOT/firefox-100.0.1-1.fc35.i386/usr/lib/firefox/firefox and /builddir/build/BUILDROOT/firefox-100.0.1-1.fc35.i386/usr/lib/firefox/firefox-bin
    absolute symlink: /usr/lib/firefox/dictionaries -> /usr/share/myspell
    Duplicate build-ids /builddir/build/BUILDROOT/firefox-100.0.1-1.fc35.i386/usr/lib/debug/usr/lib/firefox/firefox-100.0.1-1.fc35.i386.debug and /builddir/build/BUILDROOT/firefox-100.0.1-1.fc35.i386/usr/lib/debug/usr/lib/firefox/firefox-bin-100.0.1-1.fc35.i386.debug
    Installed (but unpackaged) file(s) found:
   /usr/lib/firefox/browser/defaults/preferences/firefox-redhat-default-prefs.jse
Child return code was: 1

Comment 9 Julian Sikorski 2022-05-18 22:26:43 UTC
The fix is to replace sed -ie with sed -i -e in line 912. For some reason sed -ie creates firefox-redhat-default-prefs.jse in addition to performing the change, which causes the error above.

Comment 10 Alexander Ploumistos 2022-05-18 22:38:06 UTC
From sed's manual:

-i[SUFFIX], --in-place[=SUFFIX]

       edit files in place (makes backup if SUFFIX supplied)

Comment 11 Jan Horak 2022-05-20 16:24:47 UTC
Fixed failed builds for F35: https://koji.fedoraproject.org/koji/buildinfo?buildID=1968018

Comment 12 Julian Sikorski 2022-06-08 17:28:18 UTC
This is fixed as of 101-2.fc36. Thank you!