Bug 2084655

Summary:	RFE - Allow node label capability through CR
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	jrickard
Component:	ocs-operator	Assignee:	Nikhil Ladha <nladha>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	bkunal, etamir, mmuench, muagarwa, nladha, odf-bz-bot, sostapov
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-11 07:15:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description jrickard 2022-05-12 15:20:39 UTC

Description of problem (please be detailed as possible and provide log
snippests):
Deploying odf/ocs-operator through the user interface we can select specific nodes and label them with: cluster.ocs.openshift.io/openshift-storage= ; when using gitops to deploy  OpenShift Data Foundations to label the nodes we have to either:
- create a custom machineset / modify existing machineset 
- create kubernetes job with appropriate rbac to label the nodes
- manually label the nodes.

It would be nice to be able to label the nodes based on node-role or define a list.

Version of all relevant components (if applicable):
All supported versions

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
no

Is there any workaround available to the best of your knowledge?
manually apply labels

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
yes

Can this issue reproduce from the UI?
yes

If this is a regression, please provide more details to justify this:


Steps to Reproduce: 
workflow 1: Through UI
1. add odf-operator
2. add storageSystem
3. select nodes 

workflow 2: gitops:
1. manual label nodes (oc label nodes --overwrite << nodes >> cluster.ocs.openshift.io/openshift-storage='')
2. start gitops deployment

Actual results:


Expected results:


Additional info:

Comment 3 Mudit Agarwal 2022-05-31 13:24:41 UTC

No RFE in 4.11 now, will create a Jira to track the same. Putting NI on myself for the same.

Comment 13 Mudit Agarwal 2023-08-07 09:28:41 UTC

We are supposed to create the KCS, here is the format https://access.redhat.com/node/add/kcs-solution
You can reach out to Bipin Kunal if you need review before publishing.