Bug 2085443

Summary:	[IPI-Azure] Cluster with Standard_NP10s (HyperVGenerations='V1') VM instance does not enable AcceleratedNetworking
Product:	OpenShift Container Platform	Reporter:	MayXu <maxu>
Component:	Installer	Assignee:	aos-install
Installer sub component:	openshift-installer	QA Contact:	MayXu <maxu>
Status:	CLOSED DUPLICATE	Docs Contact:
Severity:	unspecified
Priority:	low	CC:	padillon
Version:	4.11
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-18 16:10:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description MayXu 2022-05-13 11:41:41 UTC

Description: Cluster with Standard_NP10s VM instance  does not enable AcceleratedNetworking

Version:   registry.ci.openshift.org/ocp/release:4.11.0-0.nightly-2022-05-11-054135
How reproducible:
always

Steps to Reproduce:
Set the vm with Standard_NP10s, region southcentralus in install-config.yaml. Create the cluster 
$az network nic list -g $RG --query "[].[name,enableAcceleratedNetworking]" -o tsv
maxu-vm1-int-svcVMNic	False
maxu-vm1-p6z8r-master-0-nic	False
maxu-vm1-p6z8r-master-1-nic	False
maxu-vm1-p6z8r-master-2-nic	False
maxu-vm1-p6z8r-worker-southcentralus-1-nic	False
maxu-vm1-p6z8r-worker-southcentralus-2-nic	False
Expected:
   All the vms enableAcceleratedNetworking is True. 

Additional info:
$ az vm list-skus --size Standard_NP10s
 "name": "HyperVGenerations",
 "value": "V1"
 "name": "AcceleratedNetworkingEnabled",
 "value": "True"

on azure stack hub, most vm ase this type, fail to enable the vm AcceleratedNetworking.

Comment 1 Patrick Dillon 2022-05-16 16:19:15 UTC

Accelerated networking is not supported on Azure Stack Hub: https://docs.microsoft.com/en-us/azure-stack/user/azure-stack-network-differences?view=azs-2108

The current behavior of the installer is "future proof" in that if accelerated networking is enabled in ASH, clusters will start working with accelerated networking without any further work.

So I would say either we should add a warning in the code, a note in the docs, or close this as NOTABUG.

Comment 2 Patrick Dillon 2022-05-16 17:37:16 UTC

I see that this is also happening in public Azure, in which case this is indeed a bug.

Comment 4 Patrick Dillon 2022-05-18 16:10:28 UTC

I tested Standard_NP10s, region southcentralus from master branch.

Control plane nodes created successfully with accelerated networking. Compute node issues look to be a duplicate of BZ#2085336 so closing this as a dupe.

*** This bug has been marked as a duplicate of bug 2085336 ***

Comment 5 MayXu 2022-05-19 01:36:16 UTC

@padillon , with vmNetworkingType: Basic on computer in install-config can avoid the disruption of bug 2085336 

Now I checked with the lastet fix on https://github.com/openshift/installer/pull/5924,https://github.com/openshift/installer/pull/5918,https://github.com/openshift/machine-api-provider-azure/pull/20,
it is ok now. 
$ az network nic list -g $RG --query "[].[name,enableAcceleratedNetworking]" -o tsv
maxu-443w-dttf8-master-0-nic	True
maxu-443w-dttf8-master-1-nic	True
maxu-443w-dttf8-master-2-nic	True
maxu-443w-dttf8-worker-southcentralus3-mm627-nic	False
maxu-443w-dttf8-worker-southcentralus3-tkxt5-nic	False
maxu-443w-dttf8-worker-southcentralus3-xzcjs-nic	False

ref install-config.yaml:
controlPlane:
  architecture: amd64
  hyperthreading: Enabled
  name: master
  platform:
    azure:
      type: Standard_NP10s
      osDisk:
        diskType: StandardSSD_LRS
  replicas: 3
compute:
- architecture: amd64
  hyperthreading: Enabled
  name: worker
  platform:
    azure:
      type: Standard_NP10s
      osDisk:
        diskType: Standard_LRS
      vmNetworkingType: Basic
  replicas: 3
metadata:
  name: maxu-443w
platform:
  azure:
    region: southcentralus

Comment 6 Red Hat Bugzilla 2023-09-15 01:54:48 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 365 days