Bug 208675
| Summary: | Review Request: miau - Full-featured IRC bouncer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jima <jima> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-10-02 22:04:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Jima
2006-09-30 02:50:13 UTC
First review of miau: 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Scriptlets requirements - This package should require /sbin/install-info as Requires(post), Requires(preun). - The scriplets of post, postun is incollect. 1. use || : 2. don't call "/sbin/install-info --delete" when upgrading. See the section "Texinfo" of: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : * The sources used to build the package must.... Well, I cannot directly access to http://dl.sf.net/%{name}/%{name}-%{version}.tar.bz2 . I prefer like: http://umn.dl.sourceforge.net/sourceforge/%{name}/%{name}-%{version}.tar.gz 3. Other things I have noticed: * I think "INSTALL" is not needed for document files. This is required for installing this. 1. You're correct; I've made the recommended changes. 2. This is a widely disputed point. I'm in the dl.sf.net camp, personally. I have qualms with changing it to point at a specific mirror; I can attest that the U of M mirror has had historical issues, as has Ibiblio. (Those are the two I typically use.) My general belief is that dl.sf.net *usually* points at a valid mirror, and that any reviewer ought to be able to puzzle out how to get a tarball if it isn't (as you clearly were). My informal poll in #fedora-extras found most of the respondants to prefer dl.sf.net, although there was an undertone that both methods pretty well suck (which I also agree with). 3. Also a fair point. I stand corrected. Updated spec/SRPM can be found at: http://beer.tclug.org/fedora-extras/miau/miau.spec http://beer.tclug.org/fedora-extras/miau/miau-0.6.2-3.src.rpm (In reply to comment #3) > 2. This is a widely disputed point. I'm in the dl.sf.net camp, personally. Well, I prefer to specify URL, however, this is not a blocker. Other things are correctly fixed. --------------------------------------------------------------------------------- This package (miau) is APPROVED by me. Thanks for the fast review! Imported into CVS, added to owners.list, built for devel, and requested FC-5 branch. All systems go. Closing with NEXTRELEASE; have a nice day! Package Change Request ====================== Package Name: miau New Branches: EL-5 Thanks! cvs done. Package Change Request ====================== Package Name: miau New Branches: EL-4 EL-5 cvs done. |