Bug 2087248

Summary:	`oc adm upgrade` should return ReleaseAccepted condition to show upgrade status.
Product:	OpenShift Container Platform	Reporter:	OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component:	oc	Assignee:	David Hurta <dhurta>
oc sub component:	oc	QA Contact:	liujia <jiajliu>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	aos-bugs, mfojtik, mifiedle, wking, yinzhou
Version:	4.11
Target Milestone:	---
Target Release:	4.10.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-31 12:40:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2065507
Bug Blocks:

Comment 4 liujia 2022-05-23 07:12:23 UTC

Verified on 4.10.0-0.nightly-2022-05-19-133122

# ./oc version
Client Version: 4.10.0-0.nightly-2022-05-19-133122
Server Version: 4.10.14
Kubernetes Version: v1.23.5+b463d71

1. Trying to upgrade a cluster to an unsigned payload.
# ./oc adm upgrade
Cluster version is 4.10.14

ReleaseAccepted=False

  Reason: RetrievePayload
  Message: Retrieving payload failed version="" image="registry.ci.openshift.org/ocp/release@sha256:60a93f1ca1a0e3db1916b201ee2c846f70ba6991cdcdac96b12e740574c9daa1" failure=The update cannot be verified: unable to locate a valid signature for one or more sources

2. Trying to upgrade a cluster to an unavailable payload.
# ./oc adm upgrade
Cluster version is 4.10.14

ReleaseAccepted=False

  Reason: RetrievePayload
  Message: Retrieving payload failed version="" image="quay.io/openshift-release-dev/ocp-release@sha256:e0719cb528dbac58ab0462637a6016aff7ce51b12d65747121a6165c170f9373" failure=Unable to download and prepare the update: deadline exceeded, reason: "DeadlineExceeded", message: "Job was active longer than specified deadline"

3. Precondition check for etcd backup
# ./oc adm upgrade
Cluster version is 4.10.14

ReleaseAccepted=False

  Reason: PreconditionChecks
  Message: Preconditions failed for payload loaded version="4.11.0-0.nightly-2022-05-20-213928" image="registry.ci.openshift.org/ocp/release@sha256:e0719cb528dbac58ab0462637a6016aff7ce51b12d65747121a6165c170f9373": Precondition "EtcdRecentBackup" failed because of "ControllerStarted": 

4. Precondition check for upgradeable=false
# ./oc adm upgrade
Cluster version is 4.10.14

Upgradeable=False

  Reason: ClusterVersionOverridesSet
  Message: Disabling ownership via cluster version overrides prevents upgrades. Please remove overrides before continuing.

ReleaseAccepted=False

  Reason: PreconditionChecks
  Message: Preconditions failed for payload loaded version="4.10.15" image="quay.io/openshift-release-dev/ocp-release@sha256:ddcb70ce04a01ce487c0f4ad769e9e36a10c8c832a34307c1b1eb8e03a5b7ddb": Precondition "ClusterVersionUpgradeable" failed because of "ClusterVersionOverridesSet": Disabling ownership via cluster version overrides prevents upgrades. Please remove overrides before continuing.

Comment 7 errata-xmlrpc 2022-05-31 12:40:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.10.16 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:4754