Bug 208744

Description of problem:

I cannot reopen bug 207274 so this is filed separately.

There is a trouble with openssl-0.9.7a-cve-2006-2940.patch. For
crypto/dh/dh_key.c is says:

+       if (BN_num_bits(dh->p) > OPENSSL_DH_MAX_MODULUS_BITS)
+               {
+               DHerr(DH_F_COMPUTE_KEY,DH_R_MODULUS_TOO_LARGE);
+               goto err;
+               }

but goto target looks like that:

err:
        BN_CTX_end(ctx);
        BN_CTX_free(ctx);
        return(ret);

As 'ctx' is not initialized yet if that guard above fires then
various unhealthy operations are tried on a garbage pointer.
Looks like a possible avenue of an attack although I do not have
an exploit.  At least a crash is fairly likely.

Instead of 'goto err;' there should be 'return(ret);' in that fragment
of the patch.  Another possiblity would be to do 'BN_CTX *ctx=NULL;'
at the function beginning but this does not really buy anything
but two "empty" function calls.

The same problem shows up in FC5 updates and likely in rawhide and
other openssl updated packages as well.

Version-Release number of selected component (if applicable):
openssl-0.9.7a-43.14