Bug 2087540

Summary: [RFE] Improve CPU info
Product: Container Native Virtualization (CNV) Reporter: Guohua Ouyang <gouyang>
Component: User ExperienceAssignee: Dana Orr <dorr>
Status: CLOSED ERRATA QA Contact: Guohua Ouyang <gouyang>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.11.0CC: gouyang, mschatzm, rsdeor, sgott, yzamir
Target Milestone: ---   
Target Release: 4.13.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-18 02:55:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
cpu number
none
change CPUs to CPU cores
none
add popover to tell user how the CPU and Mem are calculated none

Description Guohua Ouyang 2022-05-18 01:58:48 UTC
Description of problem:
Currently, it shows only the number of cores. Possible Improvements:
1. Considering sockets and threads, a proposal is to show the number of cores times of socket.
2. all places should include this change: template list/detail/edit page, catalog, vm overview/details page.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Tal Nisan 2022-05-24 12:19:16 UTC
Hi Stu,
What's your take on this issue? Currently we show and edit only cores, if you have 2 cores and 2 sockets we show only the cores (2), what should be displayed here?

Comment 2 sgott 2022-10-27 18:15:04 UTC
Ideally we should ask less possibly confusing questions.

As long as sockets and threads are 1, then the UI will yield the expected result. If those are values are not 1, they'll be multiplied by the number of cores selected (maybe a warning would be in order).

Comment 3 Guohua Ouyang 2022-10-31 05:27:59 UTC
Created attachment 1921301 [details]
cpu number

I just did a check on 4.12, the Total CPU number is actually cores * sockets * threads.

But if editing the CPU, it loads with the cores number, which causes confusion. Suggestion:
1. add a descriptive text to "CPU | Memory", explain how the CPU is calculated.
2. change "CPU" to "CPU cores"/"Cores" in the edit modal.

Comment 4 Guohua Ouyang 2022-11-07 11:42:56 UTC
Hi Ronen, 
We've talked about this issue last week and you said you will come up with a solution with the backend team, do you have any updates?

Comment 5 Guohua Ouyang 2022-11-28 10:06:20 UTC
Created attachment 1927990 [details]
change CPUs to CPU cores

Comment 6 Guohua Ouyang 2022-11-28 10:07:08 UTC
Created attachment 1927991 [details]
add popover to tell user how the CPU and Mem are calculated

Comment 7 Guohua Ouyang 2022-11-28 11:02:39 UTC
(In reply to Guohua Ouyang from comment #3)
> Created attachment 1921301 [details]
> cpu number
> 
> I just did a check on 4.12, the Total CPU number is actually cores * sockets
> * threads.
> 
> But if editing the CPU, it loads with the cores number, which causes
> confusion. Suggestion:
> 1. add a descriptive text to "CPU | Memory", explain how the CPU is
> calculated.
> 2. change "CPU" to "CPU cores"/"Cores" in the edit modal.

Discussed the issue with Ronen, Yifat and Foday, the agreement is:
1. add a popover to the title telling user how the CPUs are calculated
2. change CPUs to "CPU cores" in the modal

It apply to template page and VM page.

Comment 8 Ronen 2022-11-28 16:42:45 UTC
It will be nice if the popover will be able to show the VM / template values of threads and sockets

Comment 12 errata-xmlrpc 2023-05-18 02:55:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.13.0 Images security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:3205