Bug 2087686

Summary: Can't install submariner add-ons from UI on unsupported cloud provider
Product: Red Hat Advanced Cluster Management for Kubernetes Reporter: dbergami
Component: SubmarinerAssignee: Kevin Cormier <kcormier>
Status: CLOSED ERRATA QA Contact: Noam Manos <nmanos>
Severity: medium Docs Contact: Christopher Dawson <cdawson>
Priority: unspecified    
Version: rhacm-2.5CC: akandath, amagrawa, kcormier, mbabushk, nyechiel
Target Milestone: ---Keywords: Reopened
Target Release: rhacm-2.5.1Flags: bot-tracker-sync: rhacm-2.5.z+
Hardware: ppc64le   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-07 14:48:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
YAML is empty
none
YAML is empty
none
ACM 2.5.1: Custom Yaml for Submariner of the unsupported platform
none
ACM 2.5.1: Unsupported platform for Submariner addon warning none

Description dbergami 2022-05-18 08:55:45 UTC
**What happened**:
I am trying to install submariner add-ons from the UI on two ppc64le clusters in IBM Cloud.
IBM Cloud is not a supported provider so some manual steps are required, but we used to be able to install the submariner add-ons using the UI anyway.

**What you expected to happen**:
Submariner add-ons should install even if the cloud provider is not supported.

**How to reproduce it (as minimally and precisely as possible)**:
Try to install submariner add-ons from UI with clusters managed by unsupported cloud provider.

**Anything else we need to know?**:

**Environment**:
- Submariner version (use `subctl version`):
- Kubernetes version (use `kubectl version`):
- Diagnose information (use `subctl diagnose all`):
- Gather information (use `subctl gather`)
- Cloud provider or hardware configuration:
- OS (e.g `cat /etc/os-release`):
- Kernel (e.g `uname -a`):
- Install tools:
- Others:

Comment 1 dbergami 2022-05-18 08:58:40 UTC
Created attachment 1880723 [details]
YAML is empty

Comment 2 dbergami 2022-05-18 08:59:16 UTC
Created attachment 1880724 [details]
YAML is empty

Comment 3 dbergami 2022-05-18 09:04:00 UTC
The YAML generated bythe UI should contain at least the Broker and the two ManagedClusterAddOn.
This is what we do to deploy submariner from the CLI:

$ oc apply -f - << EOF 
apiVersion: addon.open-cluster-management.io/v1alpha1 
kind: ManagedClusterAddOn
metadata:
  name: submariner
  namespace: local-cluster
spec:
  installNamespace: submariner-operator
EOF

$ oc apply -f - << EOF 
apiVersion: addon.open-cluster-management.io/v1alpha1 
kind: ManagedClusterAddOn
metadata:
  name: submariner
  namespace: roks-cluster
spec:
  installNamespace: submariner-operator
EOF

$ oc apply -f - << EOF
apiVersion: submariner.io/v1alpha1
kind: Broker
metadata:
  name: submariner-broker
  namespace: submariner-broker
spec:
  globalnetEnabled: false
EOF

Comment 4 dbergami 2022-05-18 09:19:17 UTC
The initial YAML generated by UI contains:

apiVersion: addon.open-cluster-management.io/v1alpha1
kind: ManagedClusterAddOn
metadata:
  name: submariner
  namespace: ""
spec:
  installNamespace: submariner-operator
---
apiVersion: submarineraddon.open-cluster-management.io/v1alpha1
kind: SubmarinerConfig
metadata:
  name: submariner
  namespace: ""
spec:
  gatewayConfig:
    gateways: 0
  IPSecNATTPort: 0
  NATTEnable: false
  cableDriver: ""
  credentialsSecret:
    name: ""
---
apiVersion: submariner.io/v1alpha1
kind: Broker
metadata:
  name: submariner-broker
  namespace: submariner-broker
spec:
  globalnetEnabled: false



but as soon as I select a target cluster that is not from a supported provider, the YAML becomes empty.
While it should remove the SubmarinerConfig entry, the other entries should be preserved.

Comment 5 Nir Yechiel 2022-06-20 07:51:36 UTC
*** Bug 2098087 has been marked as a duplicate of this bug. ***

Comment 6 Kevin Cormier 2022-06-21 15:00:57 UTC
@noam manos Please verify fixed in 2.5.1. Thanks.

Comment 7 Maxim Babushkin 2022-06-23 15:34:23 UTC
Unfortunately, since the mentioned platform is not officially supported by the submariner yet and we don't have a resources mentioned in the BZ, we unable to verify the bug.

Comment 8 Nir Yechiel 2022-06-24 13:19:24 UTC
Since we had customers complaining about this, I'd like to get it fixed in 2.5.1 if possible. Let me see if I can find some clusters and verify myself.

Comment 10 Noam Manos 2022-06-29 20:38:41 UTC
Created attachment 1893479 [details]
ACM 2.5.1: Custom Yaml for Submariner of the unsupported platform

Comment 11 Noam Manos 2022-06-29 20:41:18 UTC
Created attachment 1893480 [details]
ACM 2.5.1: Unsupported platform for Submariner addon warning

Comment 12 Noam Manos 2022-06-29 20:42:45 UTC
Verified on ACM 2.5.1 - See screenshot attached.

Comment 17 errata-xmlrpc 2022-07-07 14:48:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat Advanced Cluster Management 2.5.1 security updates and bug fixes), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5531