Bug 2087984

Summary: Version of Source Code Pro currently packaged breaks in some cases
Product: [Fedora] Fedora Reporter: James Harmison <jharmiso>
Component: adobe-source-code-pro-fontsAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: afranke, eclipseo, fonts-bugs, mark, mattrose, r9290x
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-26 17:33:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
A screenshot of dmesg in Alacritty with Source Code Pro selected none

Description James Harmison 2022-05-18 15:26:26 UTC 
Created attachment 1880946 [details]
A screenshot of dmesg in Alacritty with Source Code Pro selected

Description of problem:
Source Code Pro version 2.030, currently packaged for all versions of Fedora and in EPEL, includes an SVG table that causes the freetype library to be unable to calculate cell height, resulting in unusable output with lines stacked on top of each other.

Version-Release number of selected component (if applicable):
2.030.1.050-<any>

How reproducible:
Always

Steps to Reproduce:
1. Install adobe-source-code-pro-fonts and alacritty (a terminal emulator that uses freetype through the crossfont crate) from the current release versions.
2. Configure alacritty to use Source Code Pro. Example config:
~/.config/alacritty/alacritty.yml:
```yaml
font:
  normal:
    family: Source Code Pro
    style: Regular
  bold:
    family: Source Code Pro
    style: Bold
  italic:
    family: Source Code Pro
    style: Italic
  bolt_italic:
    family: Source Code Pro
    style: Bold Italic
  size: 10
```
3. Launch alacritty and attempt to use the terminal

Actual results:
The terminal is completely unusable with 1px line height, although the font is rendering at the correct size.

Expected results:
The terminal has a normal font display behavior and is usable.

Additional info:
2.038 is available and appears to fix the issue (https://github.com/adobe-fonts/source-code-pro/releases)
See some additional discussion here: https://github.com/alacritty/alacritty/issues/6048
Comment 1 Ben Cotton 2022-08-09 13:16:08 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.
Comment 2 Hasshu 2023-06-26 10:44:56 UTC 
The packaged fonts are nearly 7 years (!) old at this point, whereas the most recent versions have been released this April: https://github.com/adobe-fonts/source-code-pro/releases

Please, update the relevant package(s).
Comment 3 Robert-André Mauchin 🐧 2023-08-19 07:19:42 UTC 
Could you take a look at the latest PR updating the project?

 - convert to SPDX: https://src.fedoraproject.org/rpms/adobe-source-code-pro-fonts/pull-request/2
 - convert your repo to autorelease/autochangelog with rpmautospec convert
 - then update your package with https://src.fedoraproject.org/rpms/adobe-source-code-pro-fonts/pull-request/3
Comment 4 Robert-André Mauchin 🐧 2023-08-19 10:57:55 UTC 
Ok so various contributors have proposed PRs and I rebased them so they can be pushed in succession :

 - Step 1: Remove archive from GIT  https://src.fedoraproject.org/rpms/adobe-source-code-pro-fonts/pull-request/4
 - Step 2: Convert to rpmautospec  https://src.fedoraproject.org/rpms/adobe-source-code-pro-fonts/pull-request/5
 - Step 3: Update License tag for SPDX migration https://src.fedoraproject.org/rpms/adobe-source-code-pro-fonts/pull-request/2
 - Step 4: Update to latest version  https://src.fedoraproject.org/rpms/adobe-source-code-pro-fonts/pull-request/3

The latest PR was proposed by a non-packager to update the package, but I have heavily modified it to follow the new fonts guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/

I contacted you through Mastodon where you seem to be active, I intend to push these in one week if you do not answer.
Comment 5 Robert-André Mauchin 🐧 2023-08-26 17:33:21 UTC 
https://bodhi.fedoraproject.org/updates/?search=&packages=adobe-source-code-pro-fonts&user=eclipseo
Comment 6 Hasshu 2023-08-30 16:46:14 UTC 
Many thanks!