Bug 208835
Summary: | EA set failure when restoring immutable file | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andrew Kroeger <mb6zcpv02> | ||||||
Component: | dump | Assignee: | Adam Tkac <atkac> | ||||||
Status: | CLOSED RAWHIDE | QA Contact: | Ben Levenson <benl> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | 5 | CC: | dwalsh, mmalik, ovasik, stelian | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2007-01-29 12:25:03 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Andrew Kroeger
2006-10-02 10:44:41 UTC
Created attachment 142282 [details]
test package
Please, could you test this package? problem could be fixed here. Thanks much
The SELinux patches in the updated package did not correct the problem. After further investigation, I found that the restore code was restoring the flags before trying to set the SELinux context. After the immutable flag set, no file modifications (EA attributes, update timestamps, etc.) can be made. I will attach the patch that I came up with that solved my specific problem. Created attachment 146737 [details]
Patch that solves the problem initially reported
The basic idea of this patch is to make all necessary changes (EA attributes,
timestamps, etc.) before restoring the flags.
I cannot provide any guarantees with this patch, as I did not test anything
beyond the specific error I reported. Although things looked good when I made
a quick review, there may be side-effects or corner cases involving the
relocation of the timestamp updates that I did not see.
Yes, your patch looks fine. I've added it to rawhide. Thanks for it |