Bug 2088434

Summary: [ODF-to-ODF] Misleading logs/status when ocs-consumer re-installed with the same onboarding-ticket which was used previously
Product: [Red Hat Storage] Red Hat OpenShift Data Foundation Reporter: Yashvardhan Kukreja <ykukreja>
Component: ocs-operatorAssignee: Nitin Goyal <nigoyal>
Status: POST --- QA Contact: Itzhak <ikave>
Severity: low Docs Contact:
Priority: low    
Version: 4.10CC: aeyal, ebenahar, nigoyal, odf-bz-bot, sostapov
Target Milestone: ---   
Target Release: ODF 4.14.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yashvardhan Kukreja 2022-05-19 12:49:53 UTC
Description of problem:

Upon re-installing an ocs-consumer addon on the same cluster with the same onboarding ticket, the installation fails despite it working when it got installed for the first time.

The storagecluster CR on the consumer cluster gets stuck in "Error" phase.

Digging into YAML output, it turns out that it fails at "Failed to get storageConsumer" which is somewhat of a misleading log.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a cluster
2. Install ocs-consumer addon on it.
3. Uninstall that ocs-consumer addon.
4. (Re)install the ocs-consumer addon on it again with the same onboarding-ticket which was used during the previous installation.
5. Wait for the storagecluster CR on that cluster to enter the "Error" Phase.

Actual results:
StorageCluster CR in the consumer cluster stuck on "Error" phase.
Logs suggesting that it failed to get a storageconsumer.

```
  - lastHeartbeatTime: "2022-05-19T12:37:28Z"
    lastTransitionTime: "2022-05-19T12:36:34Z"
    message: 'Error while reconciling: rpc error: code = Internal desc = Failed to
      get storageConsumer. storageconsumers.ocs.openshift.io "storageconsumer-abcc2916-fc8c-4d89-996b-9bf32ea3e75f"
      not found'
```

Expected results:
StorageCluster CR in the consumer cluster stuck on "Error" phase with the .status denoting that the fault was due to the re-use of onboarding-ticket.


Additional info: