Bug 2090335

Summary:	CVE-2022-21680 grafana: marked: regular expression block.def may lead Denial of Service [fedora-all]
Product:	[Fedora] Fedora	Reporter:	Sandipan Roy <saroy>
Component:	grafana	Assignee:	Andreas Gerstmayr <agerstmayr>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	36	CC:	agerstmayr, jkurik, mgoodwin, nathans
Target Milestone:	---	Keywords:	Security, SecurityTracking
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-20 12:26:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2082705

Description Sandipan Roy 2022-05-25 14:31:33 UTC

This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of fedora-all.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

Comment 1 Sandipan Roy 2022-05-25 14:31:35 UTC

Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# low, medium, high, urgent (required)
severity=medium

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=2082705,2090335

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Andreas Gerstmayr 2022-05-25 15:53:48 UTC

$ yarn why marked
yarn why v1.22.10
[1/4] Why do we have the module "marked"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "marked.1"
info Reasons this module exists
   - "_project_#@grafana#data" depends on it
   - Hoisted from "_project_#@grafana#data#marked"
info Disk size without dependencies: "332KB"
info Disk size with unique dependencies: "332KB"
info Disk size with transitive dependencies: "332KB"
info Number of shared dependencies: 0
Done in 2.49s.


Grafana is using this library.
The "Text" panel in Grafana accepts Markdown, and the "marked" library is used to convert Markdown to HTML.
Creating and modifying dashboards requires an user account with elevated privileges (Editor or Admin), so this vulnerability can only be exploited/persisted by a malicious Editor or Administrator.

Grafana v8.4.0+ resolves this vulnerability by upgrading the "marked" library.
The plan is to rebase Grafana from v7 to v8.x in Fedora in June or July.