Bug 2090678

Summary: Cannot create SR-IOV VF on RHEL 9.1
Product: Red Hat Enterprise Linux 9 Reporter: Mingyu Shi <mshi>
Component: nisporAssignee: Thomas Haller <thaller>
Status: CLOSED ERRATA QA Contact: Mingyu Shi <mshi>
Severity: urgent Docs Contact:
Priority: high    
Version: 9.1CC: ferferna, jiji, jishi, network-qe, sfaye, thaller, till
Target Milestone: rcKeywords: Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-15 10:31:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mingyu Shi 2022-05-26 10:19:27 UTC
Description of problem:
Cannot create SR-IOV VF on RHEL 9.1.
When a VF is created(by the other method), the "sr-iov" key gets lost from `nmstatectl show`
The NIC driver doesn't matter according to my test.

It works well using nmstatectl-rust on RHEL 9.0.

Version-Release number of selected component (if applicable):
nmstate-2.1.1-0.alpha.20220519.437e4a9.el9.x86_64
NetworkManager-1.39.5-1.el9.x86_64
Linux dell-per740-79.rhts.eng.pek2.redhat.com 5.14.0-96.el9.x86_64 #1 SMP PREEMPT_DYNAMIC Thu May 19 07:21:30 EDT 2022 x86_64 x86_64 x86_64 GNU/Linux
DISTRO=RHEL-9.1.0-20220524.0

How reproducible:
100%

Steps to Reproduce:
cat << EOF > i40e0.yaml
interfaces:
- name: ens1f0
  type: ethernet
  state: up
  ethernet:
    sr-iov:
      total-vfs: 1
EOF
nmstatectl apply i40e0.yaml

Actual results:
[2022-05-26T09:07:22Z WARN  nmstate::net_state] nm_checkpoint_rollback() failed: Bug: DbusConnectionError: org.freedesktop.NetworkManager.InvalidArguments: checkpoint /org/freedesktop/NetworkManager/Checkpoint/10 does not exist dbus: Some(MethodError("org.freedesktop.NetworkManager.InvalidArguments", Some("checkpoint /org/freedesktop/NetworkManager/Checkpoint/10 does not exist"), Msg { type: Error, sender: ":1.239", reply-serial: 2, body: Signature: [
        s (115),
    ] }))
NmstateError: VerificationError: Verification failure: ens1f0.interface.ethernet.sr-iov.total-vfs desire '1', current '0'

Expected results:
No failure

Additional info:
When there is no vf, the "ethernet" subtree of `nmstatectl show` looks like:
ethernet:
      sr-iov:
        total-vfs: 0
        vfs: []
      auto-negotiation: false
      speed: 10000
      duplex: full

after a vf is created, the "sr-iov" key gets lost:
[17:13:34@dell-per740-79 ~]1# echo 1 >/sys/class/net/ens1f1/device/sriov_numvfs 
[17:13:41@dell-per740-79 ~]0# nmstatectl show ens1f1
    ethernet:
      auto-negotiation: false
      speed: 10000
      duplex: full

Comment 1 Thomas Haller 2022-06-15 23:27:16 UTC
it's a bug in nispor. Reassigning.

Comment 4 Thomas Haller 2022-06-29 10:51:46 UTC
fixed upstream: https://github.com/nispor/nispor/pull/199

Comment 7 Mingyu Shi 2022-07-04 05:46:45 UTC
Verified with versions:
nmstate-2.1.2-1.el9.x86_64
NetworkManager-1.39.7-2.el9.x86_64

Comment 9 errata-xmlrpc 2022-11-15 10:31:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nispor bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8170