Bug 2090977

Summary: [Machines] [RFE] Interface list is not sorted correctly
Product: Red Hat Enterprise Linux 9 Reporter: g.danti
Component: cockpit-machinesAssignee: Nobody <nobody>
Status: CLOSED ERRATA QA Contact: Xianghua Chen <xchen>
Severity: low Docs Contact:
Priority: unspecified    
Version: 9.0CC: kkoukiou, mmarusak, mpitt, wshi, xchen, ymao, yunyang
Target Milestone: rcKeywords: FutureFeature, Triaged
Target Release: 9.3Flags: pm-rhel: mirror+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-machines-288-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-07 08:24:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot none

Description g.danti 2022-05-27 07:36:48 UTC
Created attachment 1884042 [details]
screenshot

Description of problem:
When using cockpit-machines to add/edit a VM network settings, the wizard shows all available interfaces as unsorted entries (see screenshot).

It would be very useful to alphabetically sort the interface list, maybe even putting the (sorted) physical interfaces on top (or with a checkbox to only show physical interfaces).

Version-Release number of selected component (if applicable):
cockpit-machines-268-1.el9.noarch.rpm

How reproducible:
Add/edit a virtual machine interface

Steps to Reproduce:
1. log in to cockpit
2. go to the virtual machine tab
3. add/edit a virtual interface

Actual results:
The interface list is unsorted.

Expected results:
The interface list should be sorted, preferably with physical interfaces on top.

Additional info:
None.

Comment 1 Martin Pitt 2023-04-11 12:55:20 UTC
Fixed in https://github.com/cockpit-project/cockpit-machines/pull/1014 , thanks Simon!

Comment 4 Xianghua Chen 2023-04-27 03:01:23 UTC
Verified with packages:
cockpit-machines-288-1.el9.noarch
cockpit-290-1.el9.x86_64
libvirt-daemon-9.0.0-10.el9_2.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64

Steps:
1 Prepare a cirros image
2 Enter vm details page, click "Add network interface“
3 Choose "Virtual network", "Bridge to LAN", "Direct attachment" seperately, and check the "Source" list.
The interface list is sorted.

So verified.

Comment 7 errata-xmlrpc 2023-11-07 08:24:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-machines bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6336