Bug 2091749

Summary: rlwrap built for F36 sets a version number with a minor version to the env RLWRAP_VERSION
Product: [Fedora] Fedora Reporter: Hisanobu Okuda <hokuda>
Component: rlwrapAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: michel
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rlwrap-0.45.2-3.fc38 rlwrap-0.45.2-2.el8 rlwrap-0.45.2-2.el7 rlwrap-0.45.2-3.fc36 rlwrap-0.45.2-3.el9 rlwrap-0.45.2-3.fc35 rlwrap-0.45.2-3.fc37 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-09-28 20:04:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Hisanobu Okuda 2022-05-31 01:31:45 UTC
Description of problem:

    rlwrap built for F36 sets a version number with a minor version to the
    env RLWRAP_VERSION. It breaks the version checking functionality of
    rlwrapfilter.py.

Version-Release number of selected component (if applicable):

    rlwrap-0.45.2-1.fc36.x86_64

How reproducible:


Steps to Reproduce:
1. cd /usr/share/rlwrap/filters/
2. /usr/bin/rlwrap -z null.py cat
Traceback (most recent call last):
  File "/usr/share/rlwrap/filters/null.py", line 13, in <module>
    import rlwrapfilter
  File "/usr/share/rlwrap/filters/rlwrapfilter.py", line 74, in <module>
    rlwrap_version = float(os.environ.get('RLWRAP_VERSION', "0.41"))
ValueError: could not convert string to float: '0.45.2'
rlwrap: error: error writing to filter: Broken pipe
rlwrap: warning: filter died
warnings can be silenced by the --no-warnings (-n) option


Actual results:


Expected results:


Additional info:

    The original rlwrap 0.45.2 hosted in the github sets "0.45"
    but not "0.45.2".

Comment 1 Michel Lind 2022-09-28 01:51:11 UTC
Interesting, given... we get our sources from GitHub too. And the VERSION is set by Makefile.in. Seems like rlwrapfilter.py should be modified to support patch releases.

Comment 2 Michel Lind 2022-09-28 01:55:48 UTC
Seems this is reported upstream. https://github.com/hanslub42/rlwrap/issues/161 -- I can put up a PR to fix this.

Comment 3 Fedora Update System 2022-09-28 20:01:54 UTC
FEDORA-2022-e5ca44eabb has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e5ca44eabb

Comment 4 Fedora Update System 2022-09-28 20:04:03 UTC
FEDORA-2022-e5ca44eabb has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2022-09-28 21:07:42 UTC
FEDORA-2022-a0891277e7 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a0891277e7

Comment 6 Fedora Update System 2022-09-28 21:07:43 UTC
FEDORA-2022-068ead2139 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-068ead2139

Comment 7 Fedora Update System 2022-09-28 21:07:44 UTC
FEDORA-2022-1a83e23f76 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1a83e23f76

Comment 8 Fedora Update System 2022-09-28 21:07:44 UTC
FEDORA-EPEL-2022-690e55a2ff has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-690e55a2ff

Comment 9 Fedora Update System 2022-09-28 21:07:45 UTC
FEDORA-EPEL-2022-be279a7627 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-be279a7627

Comment 10 Fedora Update System 2022-09-28 21:07:45 UTC
FEDORA-EPEL-2022-04cccae3c4 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-04cccae3c4

Comment 11 Fedora Update System 2022-09-29 04:17:44 UTC
FEDORA-2022-068ead2139 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-068ead2139`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-068ead2139

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-09-29 04:27:06 UTC
FEDORA-EPEL-2022-04cccae3c4 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-04cccae3c4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-09-29 04:39:53 UTC
FEDORA-2022-a0891277e7 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-a0891277e7`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a0891277e7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-09-29 04:49:41 UTC
FEDORA-EPEL-2022-690e55a2ff has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-690e55a2ff

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-09-29 05:01:26 UTC
FEDORA-2022-1a83e23f76 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1a83e23f76`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1a83e23f76

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2022-09-29 05:05:50 UTC
FEDORA-EPEL-2022-be279a7627 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-be279a7627

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-10-06 14:54:26 UTC
FEDORA-EPEL-2022-690e55a2ff has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2022-10-06 15:02:20 UTC
FEDORA-EPEL-2022-04cccae3c4 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2022-10-06 15:14:54 UTC
FEDORA-2022-068ead2139 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2022-10-06 15:48:59 UTC
FEDORA-EPEL-2022-be279a7627 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2022-10-06 16:20:25 UTC
FEDORA-2022-1a83e23f76 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Hisanobu Okuda 2022-10-06 23:10:00 UTC
I confirmed it works on F35.
Thanks!

Comment 23 Fedora Update System 2022-11-10 22:08:10 UTC
FEDORA-2022-a0891277e7 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.