Bug 2092091
| Summary: | Install Using GPT on x86_64 BIOS by Default | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Cotton <bcotton> |
| Component: | Changes Tracking | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 37 | CC: | awilliam, bcotton, bugzilla, davide, michel, ngompa13, vslavik |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-11-15 16:22:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2016049 | ||
|
Description
Ben Cotton
2022-05-31 18:55:36 UTC
Today we reached the Code Complete (Testable) milestone on the F37 schedule: https://fedorapeople.org/groups/schedule/f-37/f-37-key-tasks.html At this time, all F37 Changes should be complete enough to be testable. You can indicate this by setting this tracker to the MODIFIED status. If the Change is 100% code complete, you can set the tracker to ON_QA. If you need to defer this Change to F38, please NEEDINFO me. Changes that have not reached at least the MODIFIED status will be given to FESCo for evaluation of contingency plans. This just landed in Anaconda upstream: https://github.com/rhinstaller/anaconda/pull/4232 Today we reached the Code Complete (100% complete) milestone on the F37 schedule: https://fedorapeople.org/groups/schedule/f-37/f-37-key-tasks.html At this time, all F37 Changes should be 100% complete. You can indicate this by setting this tracker to the ON_QA status. If you need to defer this Change to F38 please NEEDINFO me. Note that we are entering the Beta freeze. Additional package changes to complete this Change will need an approved blocker or freeze exception. See https://fedoraproject.org/wiki/QA:SOP_blocker_bug_process and https://fedoraproject.org/wiki/QA:SOP_freeze_exception_bug_process for more information. Changes that have not reached the ON_QA status will be given to FESCo for evaluation of contingency plans. This has landed for a while now: https://koji.fedoraproject.org/koji/buildinfo?buildID=2046418 F37 was released today, so I am closing this tracker. If this Change was not completed, please notify me ASAP. So, it took a while, but I figured out this caused a bit of a problem. The patch that was merged doesn't do exactly what the bug and Change request - or rather, it does *more* than what was requested. It makes GPT the default disk label *in any situation in which blivet lists it as supported at all*. The resulting codepath is kinda strange, really, if you think it through. blivet has code that carefully constructs the list of supported disk labels in different preference orders for different situations: https://github.com/storaged-project/blivet/blob/3.8-devel/blivet/formats/disklabel.py#L222 to me, the logical thing to do would have been to extend that so it always returns ["gpt", "msdos"] on x86_64 (but not change it otherwise). That would have achieved precisely what the Change claimed to want to do. But instead, we added code to anaconda that effectively ignores the careful logic in blivet and just always prefers GPT if it's in the list at all (unless you override it with a cmdline arg): https://github.com/rhinstaller/anaconda/pull/4232 This affects more cases than was claimed. It's a bit hard to parse out exactly how many, but I found one specific one: this Change results in us preferring GPT disk labels on ppc64le, when we previously preferred msdos labels. And it turns out ppc64le installs to a GPT-labeled disk just don't boot, at least on qemu with SLOF (the firmware used for ppc64le qemu VMs): https://bugzilla.redhat.com/show_bug.cgi?id=2209760 blivet PR to achieve something closer to the original intent: https://github.com/storaged-project/blivet/pull/1132 I will also write an anaconda PR to have it stop overriding blivet's ordering. anaconda PR: https://github.com/rhinstaller/anaconda/pull/4795 Both PRs merged now, awaiting anaconda-39.19 |