Bug 2092951

Summary: “Edit BootSource” action should have more explicit information when disabled
Product: Container Native Virtualization (CNV) Reporter: Yifat Menchik <yfrimanm>
Component: User ExperienceAssignee: Ugo Palatucci <upalatuc>
Status: CLOSED ERRATA QA Contact: Leon Kladnitsky <lkladnit>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.11.0CC: apinnick, cnv-qe-bugs, ctomasko, gouyang, lkladnit, oramraz, ycui, yfrimanm
Target Milestone: ---   
Target Release: 4.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2091856 Environment:
Last Closed: 2022-09-14 19:35:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Red Hat Template that doesn’t use source reference
none
Red Hat Template that uses source reference
none
Custom Template that doesn’t use source reference
none
Custom Template that uses source reference none

Description Yifat Menchik 2022-06-02 15:29:25 UTC
+++ This bug was initially created as a clone of Bug #2091856 +++

Description of problem: When "Edit BS" action is disabled in template kebab it should has helper text with the reason why it's disabled, see attached screenshot


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Yifat Menchik on 2022-05-31 10:01:17 UTC ---

@apinnick can you please advise? Thank you.

--- Additional comment from Avital Pinnick on 2022-05-31 10:16:23 UTC ---

@yfrimanm 
Unless I am missing something, I think it is self-explanatory. The user cannot edit Red Hat Supported or Red Hat Provided templates in any way, including changing the boot source. This is in the documentation: https://docs.openshift.com/container-platform/4.10/virt/vm_templates/virt-creating-vm-template.html

If a user wants to edit the boot source, they would have to first clone the template. Then it becomes a User Supported or User Provided template. 

If this were a tooltip, you could add a line about cloning the template. I do not think you will have enough room on a menu to add more text.

--- Additional comment from Yifat Menchik on 2022-06-01 12:48:07 UTC ---

@apinnick this is more complexed than that so I will schedule a meeting to get the accurate explanations from @yzamir

--- Additional comment from Yifat Menchik on 2022-06-02 15:25:30 UTC ---

We agreed about 3 states for Edit of the Boot Source:
1. Edit Boot source - this will affect only the selected template 
2. Edit Boot reference - this will change the Boot source that may be used by other templates
3. Edit Boot source (action is disabled) in case the Boot source can't be edited

Comment 1 Yifat Menchik 2022-06-06 15:34:03 UTC
Created attachment 1887215 [details]
Red Hat Template that doesn’t use source reference

Comment 2 Yifat Menchik 2022-06-06 15:34:28 UTC
Created attachment 1887216 [details]
Red Hat Template that uses source reference

Comment 3 Yifat Menchik 2022-06-06 15:35:02 UTC
Created attachment 1887217 [details]
Custom Template that doesn’t use source reference

Comment 4 Yifat Menchik 2022-06-06 15:35:29 UTC
Created attachment 1887218 [details]
Custom Template that uses source reference

Comment 5 Ugo Palatucci 2022-06-09 13:34:03 UTC
pr here: https://github.com/kubevirt-ui/kubevirt-plugin/pull/581

Comment 6 Guohua Ouyang 2022-06-17 06:07:13 UTC
verified on v4.11.0-58

Comment 9 errata-xmlrpc 2022-09-14 19:35:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.11.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:6526