Bug 2092965
| Summary: | Review Request: libkrunfw - A dynamic library bundling the guest payload consumed by libkrun | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sergio Lopez <slopezpa> |
| Component: | Package Review | Assignee: | Cole Robinson <crobinso> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | crobinso, fabiano, package-review |
| Target Milestone: | --- | Flags: | crobinso:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-06-17 11:38:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sergio Lopez
2022-06-02 16:03:52 UTC
Before the kernel `Source:` line can you add a comment that bundling of the kernel package was approved by fedora kernel maintainers, and link to the discussion: https://lists.fedorahosted.org/archives/list/kernel@lists.fedoraproject.org/thread/2TMXPCE2VWF7USZA7OHQ3P2SBJAEGCSX/ * Add a comment explaining the exclusivearch. `package only buildable for $ARCHES` is enough IMO * Typo 'pacakge' * Use %make_install PREFIX=%{_prefix} BuildRequires: I see the list is copied from kernel distgit but a lot of that is redundant and possibly not even used with your libkrunfw config. First you can remove everything that's explicitly listed in the buildroot: https://pagure.io/fedora-comps/blob/main/f/comps-f37.xml.in#_324 For a f36 x86_64 build I got it down to: # libkrunfw + packaging requirements BuildRequires: gcc BuildRequires: git-core BuildRequires: make BuildRequires: python3-pyelftools # kernel build requirements BuildRequires: bison BuildRequires: flex BuildRequires: bc BuildRequires: elfutils-devel But no runtime testing, and I didn't try dropping bison+flex+bc, I just saw they were in build output. (In reply to Cole Robinson from comment #1) > Before the kernel `Source:` line can you add a comment that bundling of the > kernel package was approved by fedora kernel maintainers, and link to the > discussion: > https://lists.fedorahosted.org/archives/list/kernel@lists.fedoraproject.org/ > thread/2TMXPCE2VWF7USZA7OHQ3P2SBJAEGCSX/ > > * Add a comment explaining the exclusivearch. `package only buildable for > $ARCHES` is enough IMO > > * Typo 'pacakge' > * Use %make_install PREFIX=%{_prefix} > > BuildRequires: I see the list is copied from kernel distgit but a lot of > that is redundant and possibly not even used with your libkrunfw config. > First you can remove everything that's explicitly listed in the buildroot: > https://pagure.io/fedora-comps/blob/main/f/comps-f37.xml.in#_324 For a f36 > x86_64 build I got it down to: > > # libkrunfw + packaging requirements > BuildRequires: gcc > BuildRequires: git-core > BuildRequires: make > BuildRequires: python3-pyelftools > > # kernel build requirements > BuildRequires: bison > BuildRequires: flex > BuildRequires: bc > BuildRequires: elfutils-devel > > But no runtime testing, and I didn't try dropping bison+flex+bc, I just saw > they were in build output. You nailed the required packages, I've tried removing "bison", "flex" and "bc" individually and all of them are required. We also need "perl-interpreter" on aarch64. I've produced a new COPR build with the new spec. I think I've applied all your suggestions, please let me know if I missed something: - https://download.copr.fedorainfracloud.org/results/slp/libkrunfw/fedora-rawhide-x86_64/04501528-libkrunfw/libkrunfw.spec - https://download.copr.fedorainfracloud.org/results/slp/libkrunfw/fedora-rawhide-x86_64/04501528-libkrunfw/libkrunfw-2.1.1-1.fc37.src.rpm Thanks! Looks good to me now, setting fedora-review+ (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libkrunfw The package has hit rawhide, thanks Cole and Gwyn! |