Bug 2093852

Summary: Affinity rule created in console deployment for single-replica infrastructure
Product: OpenShift Container Platform Reporter: Jakub Hadvig <jhadvig>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.11CC: yapei
Target Milestone: ---   
Target Release: 4.12.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-17 19:49:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2111037    

Description Jakub Hadvig 2022-06-06 08:33:08 UTC
Description of problem:
Console operator erroneously creates console deployment with an affinity rule when running in a cluster with HA control plane (ControlPlaneTopology=="HighlyAvailable"/"External") and non-HA infrastructure plane (InfrastructureTopology=="SingleReplica").

Version-Release number of selected component (if applicable):


How reproducible:
To reproduce the issue, create an OCP cluster with 3 control plane nodes and 1 worker node. Console deployment will have non-empty affinity clause, even though the number of console replicas is 1:
```
kind: Deployment
apiVersion: apps/v1
...
  name: console
  ...
spec:
  replicas: 1
  ...
  template:
    ...
    spec:
      ...
      affinity:
        podAntiAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            - labelSelector:
                matchExpressions:
                  - key: component
                    operator: In
                    values:
                      - ui
              topologyKey: kubernetes.io/hostname
...
````

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
This issue causes console deployment updates to stall because new console replica will not start on the same single worker node due to the anti-affinity rule.

Comment 1 Jakub Hadvig 2022-06-06 08:34:42 UTC
Created from https://github.com/openshift/console-operator/issues/656

Comment 4 Yadan Pei 2022-07-20 02:21:41 UTC
PR was merged 6 days ago against openshift/master branch, it should be included in 4.12

Comment 6 Yadan Pei 2022-07-26 01:58:11 UTC
Create a SNO cluster

$ oc get infrastructure cluster -o json | jq .status.infrastructureTopology
"SingleReplica"
$ oc get infrastructure cluster -o json | jq .status.controlPlaneTopology 
"SingleReplica"
$ oc get deployment console -n openshift-console -o json | jq .spec.template.spec.affinity
{}
$ oc get clusterversion
NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.12.0-0.nightly-2022-07-25-122035   True        False         26m     Cluster version is 4.12.0-0.nightly-2022-07-25-122035


we can see console deployment has empty affinity, verified on 4.12.0-0.nightly-2022-07-25-122035

Comment 9 errata-xmlrpc 2023-01-17 19:49:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.12.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:7399