Bug 2094088

Summary:	Columns in NBDB may never be updated by OVNK
Product:	OpenShift Container Platform	Reporter:	Tim Rozet <trozet>
Component:	Networking	Assignee:	Tim Rozet <trozet>
Networking sub component:	ovn-kubernetes	QA Contact:	Anurag saxena <anusaxen>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	urgent
Priority:	urgent	CC:	ffernand, jcaamano, yprokule
Version:	4.11
Target Milestone:	---
Target Release:	4.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-10 11:16:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2092937

Description Tim Rozet 2022-06-06 19:44:26 UTC

Description of problem:
Due to a refactor PR to try to clean up some of the libovsdb interaction code in ovn-kube, the behavior of updating columns in the database back to their default values was changed. Previously the code would specify which columns/fields of a row that need to be updated. With the PR, now it is assumed that only fields with non-default values need to be updated:

https://github.com/ovn-org/ovn-kubernetes/pull/2800

The consequence of this is that for certain column types (map, slice, pointer) the values will never get updated if they are set back to their default value. For example, if there is a logical switch port who currently has a vlan tag of 5, and the port is updated to remove the tag, this update will never happen because of this bug. Additionally if there is a column that holds a slice or map type, and it is trying to be set back to empty that will never happen. Since this refactor touched many places in ovnk, this regression is likely across multiple features and functionality.

Comment 1 Surya Seetharaman 2022-06-09 07:41:38 UTC

*** Bug 2094903 has been marked as a duplicate of this bug. ***

Comment 7 errata-xmlrpc 2022-08-10 11:16:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069

Comment 8 Red Hat Bugzilla 2023-09-15 01:55:35 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 365 days