Bug 209429

Summary: iSCSI root oops on x86_64 xen domU
Product: [Fedora] Fedora Reporter: Mark McLoughlin <markmc>
Component: kernel-xenAssignee: Eduardo Habkost <ehabkost>
Status: CLOSED RAWHIDE QA Contact: Brian Brock <bbrock>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bstein, coughlan, dshaks, ehabkost, jmh, mchristi, redhat2, rkenna, sct, wtogami, xen-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-05-22 22:26:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 215581    
Attachments:
Description Flags
iscsi-x86_64-no_iommu_init.patch none

Description Mark McLoughlin 2006-10-05 11:45:21 UTC
With iSCSI root on x86_64 DomU I was seeing an oops in
scsi_calculate_bounce_limit() where PCI_DMA_BUS_IS_PHYS() was called.
Issue is that dma_ops is NULL.

This changeset fixes it:

http://xenbits.xensource.com/ext/linux-2.6.tip-xen.hg?cs=e5a7f30e1db3

Comment 2 Mark McLoughlin 2006-10-05 13:00:21 UTC
Background is unless no_iommu_init() is called, dma_ops on x86_64 is NULL
causing the scsi subsystem to oops when trying to use iSCSI root.

The patch basically fixes a merge error. While porting the xen stuff to 2.6.28,
the iommu init stuff from x86/kernel/pci-dma.c was copied to
i386/kernel/pci-dma-xen.c and the pci_iommu_init() function appears to have been
dropped.

Patch was worked out between cdub and myself and just brings us back in line
with upstream kernel.org. I'm running both my x86_64 dom0 and domU with it.
There doesn't appear to be any regressions.

What I'm not clear on is why the problem didn't result in more oops than just
with iSCSI.

Comment 3 Mark McLoughlin 2006-11-14 18:34:53 UTC
*** Bug 215463 has been marked as a duplicate of this bug. ***

Comment 5 Mark McLoughlin 2006-11-14 18:43:39 UTC
Created attachment 141168 [details]
iscsi-x86_64-no_iommu_init.patch

Comment 6 Egon Kastelijn 2007-01-21 20:43:13 UTC
I am having the same problem with kernel 2.6.19-1.2895.fc6xen with
iscsi-initiator-utils-6.2.0.747-0.0.fc6 on a FC6 XenU guest.


Comment 7 Egon Kastelijn 2007-02-17 19:31:46 UTC
I updated my kernel to 2.6.19-1.2911.fc6xen using yum.
I also had to run "ethtool -K eth0 tx off" in my Xen guest to get rid of some
other TCP/IP crc problems I was having in combination with my nating Xen0.

After these two changes I am unable to reproduce the XenU kernel iscsi oopses I
had before.
(by the way: I did not explicitly use the above mentioned patch, but maybe it
has been integrated in the newer kernel I am using now)

So.. The problem has been solved for me!

Comment 8 Mark McLoughlin 2007-04-27 07:15:21 UTC
We still need this patch in rawhide

Comment 9 Jeremy Katz 2007-05-18 15:41:31 UTC
What's the ETA for getting this in?  We're in final freeze stages and trying to
get everything locked and ready to go for Fedora 7...

Comment 10 Jeremy Katz 2007-05-22 01:52:23 UTC
This doesn't look to be in AFAICT.

If this is going to get in for F7, it needs to get built by about noon Eastern
tomorrow as we're hoping to get an RC going tomorrow.

Comment 11 Eduardo Habkost 2007-05-22 12:53:26 UTC
F-7 build task submitted: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=14007

Comment 12 Eduardo Habkost 2007-05-22 13:01:58 UTC
Fix was committed to 'devel' branch on CVS, also.