Bug 2094783

Summary: storageclass should not be created for unsupported vsphere version
Product: OpenShift Container Platform Reporter: Wei Duan <wduan>
Component: StorageAssignee: Jonathan Dobson <jdobson>
Storage sub component: Operators QA Contact: Wei Duan <wduan>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: medium CC: jdobson, jsafrane
Version: 4.11   
Target Milestone: ---   
Target Release: 4.12.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-17 19:49:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2109977    

Description Wei Duan 2022-06-08 09:42:28 UTC
Description of problem:
Install 4.11 cluster on vSphere version 6.7.2, the CSI Driver is not installed which is expexted.
But the storageclass "thin-csi" is still created. It will make confuse when getting/using "thin-csi" sc. 

$ oc get sc
NAME             PROVISIONER                    RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
thin (default)   kubernetes.io/vsphere-volume   Delete          Immediate              false                  6h17m
thin-csi         csi.vsphere.vmware.com         Delete          WaitForFirstConsumer   true                   6h11m


$ oc -n openshift-cluster-csi-drivers get pod
NAME                                                 READY   STATUS    RESTARTS   AGE
vmware-vsphere-csi-driver-operator-668d977c9-w66zc   1/1     Running   1          5h50m

$ oc -n openshift-cluster-csi-drivers logs vmware-vsphere-csi-driver-operator-668d977c9-w66zc
I0608 01:44:35.775589       1 base_controller.go:110] Starting #1 worker of VMwareVSphereController controller ...
I0608 01:44:35.815046       1 event.go:285] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-cluster-csi-drivers", Name:"vmware-vsphere-csi-driver-operator", UID:"d40098d2-b714-4e3c-a427-9c84b2d0e041", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'ConfigMapCreated' Created ConfigMap/vsphere-csi-config -n openshift-cluster-csi-drivers because it was missing
I0608 01:44:44.202523       1 vmware.go:154] Updated category openshift-vs-qe-l4fdl with associated types
I0608 01:44:55.221889       1 vmware.go:239] Successfully created profile 6fe93b8a-e593-4c40-af74-70e95af4c50e
I0608 01:44:55.249862       1 event.go:285] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-cluster-csi-drivers", Name:"vmware-vsphere-csi-driver-operator", UID:"d40098d2-b714-4e3c-a427-9c84b2d0e041", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'StorageClassCreated' Created StorageClass.storage.k8s.io/thin-csi because it was missing
W0608 01:44:55.311484       1 vsphere_environment_checker.go:85] Overall check result: BlockUpgrade: host host-9 is on ESXI version 6.7.2, which is below minimum required version 6.7.3
I0608 01:44:55.311565       1 vspherecontroller.go:215] Scheduled the next check in 1m0.436501648s
W0608 01:44:55.311619       1 vspherecontroller.go:418] Marking cluster un-upgradeable because host host-9 is on ESXI version 6.7.2, which is below minimum required version 6.7.3

Version-Release number of selected component (if applicable):
4.11.0-0.nightly-2022-06-06-025509

How reproducible:
Always

Steps to Reproduce:
See Description.

Actual results:
storageclass "thin-csi" is present.

Expected results:
storageclass "thin-csi" should not be created if CSI Driver is not installed.

Comment 2 Wei Duan 2022-07-21 10:34:32 UTC
Verified pass on 4.12.0-0.nightly-2022-07-20-030220


Install cluster on 6.7.2 vSphere, storageclass "thin-csi" is not installed.
$ oc get sc
NAME             PROVISIONER                    RECLAIMPOLICY   VOLUMEBINDINGMODE   ALLOWVOLUMEEXPANSION   AGE
thin (default)   kubernetes.io/vsphere-volume   Delete          Immediate           false                  4h9m

Comment 7 errata-xmlrpc 2023-01-17 19:49:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.12.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:7399