Bug 209504
Summary: | Review Request: perl-POE-Component-DBIAgent - POE Component for running asynchronous DBI calls | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/POE-Component-DBIAgent/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-10-05 20:51:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-10-05 17:27:38 UTC
The only thing I can say about this is that the %description is actually less useful than the Summary:. Perhaps you could consider adding the paragraph from the README file which beging with "DBIAgent forks off"; it at least describes what the module does. But I'll leave that up to you. * source files match upstream: be7797ba7eb147c8a2f19c89806e1d4b POE-Component-DBIAgent-0.26.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(POE::Component::DBIAgent) = 0.26 perl(POE::Component::DBIAgent::Helper) = 0.03 perl(POE::Component::DBIAgent::Queue) = 0.02 perl-POE-Component-DBIAgent = 0.26-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(DBI) perl(Data::Dumper) perl(POE) perl(POE::Filter::Reference) perl(Storable) perl(constant) perl(strict) perl(vars) * %check is present and all tests pass: (well, just one test) t/1....ok All tests successful. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED %description updated. imported, built, and fork requested. Thanks for the review! :) |