Description of problem:
int kvm_arch_irqchip_create(KVMState *s)
{
if (kvm_kernel_irqchip_split()) {
perror("-machine kernel_irqchip=split is not supported on ARM.");
exit(1);
}
perror will capture the error context and print it with its own message. But there is no error context here, so the error message becomes "-machine kernel_irqchip=split is not supported on ARM.: Success". I think we should cut out ": Success" from the message, even though this is a negative test.
Version-Release number of selected component (if applicable):
qemu-kvm-7.0.0-5.el9.aarch64
How reproducible:
always
Steps to Reproduce:
1. Start qemu process with "-M kernel-irqchip=split"
# /usr/libexec/qemu-kvm -M kernel-irqchip=split
Actual results:
-machine kernel_irqchip=split is not supported on ARM.: Success
Expected results:
Cut ": Success" out from the error message.
-machine kernel_irqchip=split is not supported on ARM.
Additional info:
Only aarch64 does not support kernel-irqchip=split, so this should be an aarch64-specific issue.
https://gitlab.com/qemu-project/qemu/-/blob/master/target/arm/kvm.c#L959-964
Also can reproduce it using upstream qemu.
./build/aarch64-softmmu/qemu-system-aarch64 -version
QEMU emulator version 7.0.50 (v7.0.0-1512-gca127b3fc2)
Copyright (c) 2003-2022 Fabrice Bellard and the QEMU Project developers
./build/aarch64-softmmu/qemu-system-aarch64 -accel kvm -M virt,kernel-irqchip=split
-machine kernel_irqchip=split is not supported on ARM.: Success
Verify with qemu-kvm-7.0.0-10.el9
# /usr/libexec/qemu-kvm -version
QEMU emulator version 7.0.0 (qemu-kvm-7.0.0-10.el9)
Copyright (c) 2003-2022 Fabrice Bellard and the QEMU Project developers
# /usr/libexec/qemu-kvm -cpu host -M virt,kernel-irqchip=split
qemu-kvm: -machine kernel_irqchip=split is not supported on ARM.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory (Moderate: qemu-kvm security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHSA-2022:7967
Description of problem: int kvm_arch_irqchip_create(KVMState *s) { if (kvm_kernel_irqchip_split()) { perror("-machine kernel_irqchip=split is not supported on ARM."); exit(1); } perror will capture the error context and print it with its own message. But there is no error context here, so the error message becomes "-machine kernel_irqchip=split is not supported on ARM.: Success". I think we should cut out ": Success" from the message, even though this is a negative test. Version-Release number of selected component (if applicable): qemu-kvm-7.0.0-5.el9.aarch64 How reproducible: always Steps to Reproduce: 1. Start qemu process with "-M kernel-irqchip=split" # /usr/libexec/qemu-kvm -M kernel-irqchip=split Actual results: -machine kernel_irqchip=split is not supported on ARM.: Success Expected results: Cut ": Success" out from the error message. -machine kernel_irqchip=split is not supported on ARM. Additional info: Only aarch64 does not support kernel-irqchip=split, so this should be an aarch64-specific issue. https://gitlab.com/qemu-project/qemu/-/blob/master/target/arm/kvm.c#L959-964 Also can reproduce it using upstream qemu. ./build/aarch64-softmmu/qemu-system-aarch64 -version QEMU emulator version 7.0.50 (v7.0.0-1512-gca127b3fc2) Copyright (c) 2003-2022 Fabrice Bellard and the QEMU Project developers ./build/aarch64-softmmu/qemu-system-aarch64 -accel kvm -M virt,kernel-irqchip=split -machine kernel_irqchip=split is not supported on ARM.: Success