Bug 2096849

Summary:	Wrong message for installer step in post-upgrade to 6.11 for regular and non-SSL external DB Satellite setups
Product:	Red Hat Satellite	Reporter:	Gaurav Talreja <gtalreja>
Component:	Satellite Maintain	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Gaurav Talreja <gtalreja>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	6.11.0	CC:	apatel, egolov, ehelms, kgaikwad
Target Milestone:	Unspecified	Keywords:	Triaged, Upgrades, UserExperience
Target Release:	Unused
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-02-16 14:31:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Gaurav Talreja 2022-06-14 12:21:23 UTC

Description of problem:
An incorrect message appears for the installer step after upgrading to 6.11 both for regular and non-SSL external DB Satellite setups, which is specific to SSL external DB Satellite setup, for more info please check, https://bugzilla.redhat.com/show_bug.cgi?id=2090820#c10 

Version-Release number of selected component (if applicable):
Satellite 6.11.0 Snap 24.0
rubygem-foreman_maintain-1.0.12

How reproducible:
Always

Steps to Reproduce:
1. # foreman-maintain upgrade run --target-version 6.11 --whitelist='repositories-validate,repositories-setup'
..
--------------------------------------------------------------------------------
Run installer with Candlepin SSL CA when using external database with SSL:
| Executing installer                                                 [OK]
--------------------------------------------------------------------------------
..

2. Upon checking if the installer is being run to set this option for regular and non-SSL external DB Satellite setups, this option is UNDEF, which indicates the installer didn't run with this extra option, so this message seems inappropriate here.

# satellite-installer --full-help | grep katello-candlepin-db-ssl-ca
    --katello-candlepin-db-ssl-ca  The CA certificate to verify the SSL connection to the database with (current: UNDEF)
    --reset-katello-candlepin-db-ssl-ca Reset candlepin_db_ssl_ca to the default value (UNDEF)

Actual results:
Wrong message for regular and non-SSL external DB Satellite setups 
"Run installer with Candlepin SSL CA when using external database with SSL:"

Expected results:
Message as similar to previous installer procedure step or something appropriate 

Additional info:

Comment 1 Evgeni Golov 2023-02-16 14:02:30 UTC

This is only happening during the upgrade to 6.11 (not later versions), so I am inclined to close this as "currentrelease"?