Bug 2096930

Summary: Non-admin user cannot list an individual capsule but can list all capsules
Product: Red Hat Satellite Reporter: Pablo Hess <phess>
Component: Capsule - ContentAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: Vladimír Sedmík <vsedmik>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.10.6CC: ahumbe, apatel, jpasqual, lufu, rlavi, sajha, vsedmik
Target Milestone: 6.15.0Keywords: Triaged
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-04-23 17:12:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pablo Hess 2022-06-14 15:10:32 UTC
Description of problem:

This bug is even more relevant because the bootstrap.py script uses the /katello/api/capsules/<capsule_id> API endpoint to migrate hosts between capsules.

API requests to /katello/api/capsules/<some_capsule_id> fail if run by a non-admin user, even if said user has _all_ roles. As soon as we enable the admin flag for the user, the same API request works and returns information about the individual capsule.

In contrast, requests to /katello/api/capsules succeed without requiring the admin flag.

The information returned by the latter includes 100% of the information returned by the former, so the permission requirements for one of these two requests looks incorrect. I believe /katello/api/capsules/<capsule_id> should _not_ require the admin flag.


Version-Release number of selected component (if applicable):
Satellite 6.10 and earlier (tested on 6.9 and 6.8).


How reproducible:
100%

Steps to Reproduce:
1. Create a user on Satellite, give it all permissions but not _the_ admin flag.
2. Have an external capsule. In this example the external capsule ID is 2.
3. Query the API from Satellite itself at 2 points with the non-admin user:
    curl -k -u theuser:password https://localhost/katello/api/capsules/2
 and
    curl -k -u theuser:password https://localhost/katello/api/capsules/

Actual results:

The first curl command fails with:

{
  "error": {"message":"Resource smart_proxy not found by id '2'"}
}

The second command succeeds and returns all information about all capsules including capsule ID 2.


Expected results:

Both commands would succeed.



Additional info:

Location is not the issue here. These tests were performed on the lab and the user and capsule locations were made to match, or to differ. Location (mis)matching made no difference to the test outcomes, only the admin flag did.

Comment 2 Quinn James 2023-09-06 14:35:19 UTC
Created redmine issue https://projects.theforeman.org/issues/36726 from this bug

Comment 3 Bryan Kearney 2023-09-18 16:01:56 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36726 has been resolved.

Comment 5 Vladimír Sedmík 2024-01-08 20:49:34 UTC
Tested in 6.15.0 snap 5.0 - unauthorized user can't list or see details of any capsule now, while authorized user (with view_smart_proxies permission) can list and see details of any capsule in his org.

A minor BZ for improvement of the error message was filed: https://bugzilla.redhat.com/show_bug.cgi?id=2257333

Comment 8 errata-xmlrpc 2024-04-23 17:12:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.15.0 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:2010