Bug 2096942

Summary:	Incorrect breadcrumb text in puppet environment
Product:	Red Hat Satellite	Reporter:	Ladislav Vasina <lvasina>
Component:	Puppet	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED ERRATA	QA Contact:	Gaurav Talreja <gtalreja>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.11.0	CC:	gtalreja, lstejska, pcreech, rlavi
Target Milestone:	6.14.0	Keywords:	Regression, Triaged, UserExperience
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rubygems-foreman_puppet-6.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-08 14:18:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ladislav Vasina 2022-06-14 15:25:35 UTC

Description of problem:
Regression against: BZ1984965 
(CLOSED for Sat 6.10)

If you have the Puppet plugin enabled, then if you go to
a)
Configure > Environments > Help there is in the top left corner a breadcrumb link showing "Lifecycle environments" instead of "Puppet Environments" which should be there instead in my opinion.
b)
The same wrong breadcrumb link text is shown when trying to import environments from sat (Configure > Environments > Import environments from "your_sat.com").
c)
However, if you try to create a Puppet environment (Configure > Environments > Create Puppet Environment) it shows the correct link text "Puppet Environments" in breadcrumbs.

Version-Release number of selected component (if applicable):
Satellite 6.11.0 Snap:25
rubygem-foreman_puppet-2.0.6-1.el8sat.noarch
foreman-3.1.1.21-1.el8sat.noarch


How reproducible:
Always

Steps to Reproduce:
1. Have a 6.11 Satellite
2. Have the Puppet plugin enabled
3a. Go to  Configure > Environments > Help and check breadcrumbs
3b. Go to  Configure > Environments > Create Puppet Environment 
3c. Go to  Configure > Environments > Create Puppet Environment (IS OK)

Actual results:
Breadcrumb link text in points a) and b) is "Lifecycle Environments"

Expected results:
Breadcrumb link text in a) and b) should be as in point c) "Puppet Environments"

Additional info:

Comment 1 Ron Lavi 2023-04-04 09:11:27 UTC

Created redmine issue https://projects.theforeman.org/issues/36274 from this bug

Comment 2 Ron Lavi 2023-05-03 09:45:47 UTC

Fixed in https://github.com/theforeman/foreman_puppet/commit/3dbbff5876dedec5da5ef5e64f8e1e91fb20e50d
and will be released in the next foreman_puppet minor version,
moving to POST

Comment 4 Gaurav Talreja 2023-05-31 12:00:00 UTC

Tested on Satellite 6.14.0 Snap 1.0
Version: rubygem-foreman_puppet-5.1.2-1.el8sat.noarch

Steps:
1.Setup Satellite 6.14 with Puppet plugin enabled
2 Go to  Configure > Environments > Help and check breadcrumbs
3.Go to  Configure > Environments > Create Puppet Environment 
4.Go to  Configure > Environments > Import Puppet Environment 

Observations:
In 2) and 3) breadcrumb text in puppet environment is set correctly as `Puppet Environments`
But in 4)  breadcrumb text in puppet environment is still set incorrectly as `Lifecycle Environments`

Attaching screenshot of the same, and moving this back to ASSIGNED state.

Comment 5 Ron Lavi 2023-06-05 08:44:30 UTC

Fix for the import puppet environment page: https://github.com/theforeman/foreman_puppet/pull/354

Comment 6 Ron Lavi 2023-06-12 10:45:10 UTC

moving to POST, the fix is in foreman_puppet to 6.0.0

Comment 7 Leos Stejskal 2023-06-12 13:05:12 UTC

Upstream packaging: https://github.com/theforeman/foreman-packaging/pull/9482

Comment 8 Leos Stejskal 2023-06-23 09:10:03 UTC

upstream 3.7 cherry-pick: https://github.com/theforeman/foreman-packaging/pull/9515

Comment 9 Gaurav Talreja 2023-07-04 17:52:52 UTC

Verified.

Tested on Satellite 6.14.0 Snap 6.0
Version: rubygem-foreman_puppet-6.0.0-2.el8sat.noarch

Steps:
1.Setup Satellite 6.14 with Puppet plugin enabled
2 Go to  Configure > Environments > Help and check breadcrumbs
3.Go to  Configure > Environments > Create Puppet Environment 
4.Go to  Configure > Environments > Import Puppet Environment 

Observations:
In 2), 3), and 4) breadcrumb text in puppet environment is set correctly as `Puppet Environments`

Comment 12 errata-xmlrpc 2023-11-08 14:18:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.14 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6818