Bug 2097289

Summary: Add Support for Remote Port Mirroring in OVN
Product: Red Hat Enterprise Linux Fast Datapath Reporter: arn
Component: OVNAssignee: arn
Status: VERIFIED --- QA Contact: Jianlin Shi <jishi>
Severity: unspecified Docs Contact:
Priority: medium    
Version: RHEL 8.0CC: broose, ctrautma, gurpsing, hakhande, jiji, jishi, mmichels
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description arn 2022-06-15 11:11:30 UTC
Description of problem:
Currently there is not support in OVN to do remote mirroring of packets. 
Also the Remote mirroring of packets should work well with HW offload.

This is targeted to mirror to destinations anywhere outside the
cluster where the analyser resides and it need not be an OVN node.

Version-Release number of selected component (if applicable):


How reproducible:
NA .. Currently no commands available

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 arn 2022-06-15 11:15:29 UTC
Currently working on it. Waiting for review comments. 
Below is the patch details.

https://patchwork.ozlabs.org/project/ovn/patch/20220613135053.393095-1-abhiramrn@gmail.com/

Comment 2 arn 2022-06-23 05:49:41 UTC
Got few review comments on my previous patch(v2) from Numan.

I have addressed them and also fixed all the open issues. All tests are passing now.

Submitted v3 patch

https://patchwork.ozlabs.org/project/ovn/patch/20220622183629.369637-1-abhiramrn@gmail.com/

Comment 3 arn 2022-09-12 17:21:40 UTC
Got few more review comments from Numan and Ihar.

I have addressed those and sbumitted v6 patch

https://patchwork.ozlabs.org/project/ovn/patch/20220911142620.580796-1-abhiramrn@gmail.com/

Comment 6 arn 2022-11-14 09:26:21 UTC
Hi Gurpreet,

Currently we are supporting only GRE for remote port mirroring in context of hw-offload.
And for that we dont have any needed from NVIDIA at the moment.

For VxLan/Geneve we dont support as of now. In future if this needs to be supported we need to raise new RFE and plan for it.

Thanks & Regards,
Abhiram R N

Comment 7 arn 2022-11-14 09:27:34 UTC
Submitted v13 patch and all the tests have passed in Github

https://patchwork.ozlabs.org/project/ovn/patch/20221104190908.346220-1-abhiramrn@gmail.com/

Comment 8 arn 2022-12-12 09:14:58 UTC
Submitted the patch set with incorporating all review comments.

https://patchwork.ozlabs.org/project/ovn/list/?series=330873

Thanks & Regards,
Abhiram R N

Comment 13 Jianlin Shi 2023-02-09 02:35:50 UTC
Hi Abhiram,

Does mirror work for lsp with router type and lsp with localnet type?

Comment 14 arn 2023-02-09 08:18:11 UTC
Hi @jishi ,

Good question. 
No, it does NOT work with localnet or router type.

Just some additional information: 
In this feature we are using the OVS feature of Mirroring. And creating OVS Mirrors using the OVN commands.
So, it works only such lsps which have a corresponding mapping in OVS with external-ids set to the lsp created in OVN.

Thanks & Regards,
Abhiram R N

Comment 15 Jianlin Shi 2023-02-09 08:33:23 UTC
reported 3 bugs : bz2168009, bz2168087 and bz2168119. others works fine by now.

set Verified