Bug 2097735
| Summary: | IngressControllersNotUpgradeable: load balancer service has been modified; changes must be reverted before upgrading | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | OpenShift BugZilla Robot <openshift-bugzilla-robot> |
| Component: | Networking | Assignee: | Miciah Dashiel Butler Masters <mmasters> |
| Networking sub component: | router | QA Contact: | Hongan Li <hongli> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | urgent | ||
| Priority: | high | CC: | aos-bugs, hongli, mifiedle, mmasters, rpittau, vlaad, wking |
| Version: | 4.9 | Keywords: | FastFix |
| Target Milestone: | --- | ||
| Target Release: | 4.10.z | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: When an ingresscontroller is configured to use a LoadBalancer-type service, the ingress operator creates and manages this service, and if the operator detects that the user has modified an annotation that the operator manages on this service, then the operator sets the ingress clusteroperator's "Upgradeable" status condition "False" to block upgrades. However, the operator's check of the service's annotations had a logic error that could falsely report that the user had modified the annotations when service had no annotations.
Consequence: The ingress operator could erroneously set the ingress clusteroperator's "Upgradeable" status condition to "False", blocking upgrades, if the service had no annotations.
Fix: The logic that checks the service's annotations was fixed to handle empty annotations correctly.
Result: The ingress operator should no longer erroneously block upgrades.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-07-20 07:46:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2097555 | ||
| Bug Blocks: | 2097736 | ||
|
Description
OpenShift BugZilla Robot
2022-06-16 12:40:19 UTC
I was able to reproduce the failure using Cluster Bot and the command "test upgrade 4.9 4.10 azure,ovn". Here is the job: <https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-azure/1537476242792517632 Here is the failure: Jun 16 17:31:04.782: FAIL: Some cluster operators are not ready: ingress (Upgradeable=False IngressControllersNotUpgradeable: Some ingresscontrollers are not upgradeable: ingresscontroller "default" is not upgradeable: OperandsNotUpgradeable: One or more managed resources are not upgradeable: load balancer service has been modified; changes must be reverted before upgrading: ) I was able to verify the fix using Cluster Bot and the command "test upgrade 4.9,openshift/cluster-ingress-operator#784 4.10,openshift/cluster-ingress-operator#784 azure,ovn". Here is the job: <https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-azure/1537490526649978880>. The "IngressControllersNotUpgradeable" failure does not appear. *** Bug 2099663 has been marked as a duplicate of this bug. *** Verified upgrading 4.9.0-0.nightly-2022-06-24-070308 to 4.10.0-0.nightly-2022-07-06-083652 twice on GCP. Both upgrades were successful. @hongli Not sure if you want to do any other testing around this. and verified that ingress Upgradeable=True
$ oc get co/ingress
NAME VERSION AVAILABLE PROGRESSING DEGRADED SINCE MESSAGE
ingress 4.10.0-0.nightly-2022-07-06-083652 True False False 3h59m
$ oc get co/ingress -oyaml
<---snip--->
- lastTransitionTime: "2022-07-07T03:50:50Z"
reason: IngressControllersUpgradeable
status: "True"
type: Upgradeable
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (OpenShift Container Platform 4.10.23 bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2022:5568 |