Bug 2097746

Summary:	Review Request: perl-MooseX-Role-WarnOnConflict - Warn if classes override role methods without excluding them
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-MooseX-Role-WarnOnConflict-0.01-2.fc37 perl-MooseX-Role-WarnOnConflict-0.01-2.fc36 perl-MooseX-Role-WarnOnConflict-0.01-2.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-06-27 10:25:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2097813

Description Ralf Corsepius 2022-06-16 12:48:48 UTC

Spec URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Role-WarnOnConflict.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Role-WarnOnConflict-0.01-1.fc37.src.rpm
Description: 
When using Moose::Role, a class which provides a method a role provides
will silently override that method. This can cause strange, hard-to-debug
errors when the role's methods are not called. Simply use
MooseX::Role::WarnOnConflict instead of Moose::Role and overriding a role's
method becomes a composition-time warning. See the synopsis for a
resolution.

Fedora Account System Username: corsepiu

Comment 1 Jitka Plesnikova 2022-06-20 17:11:21 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add 'coreutils', it is needed for macro %{_fixperms}
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
      NO_PACKLIST is provided since this version.

$ rpm -qp --requires perl-MooseX-Role-WarnOnConflict-0.01-1.fc37.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(Moose)
      1 perl(Moose::Exporter)
      1 perl(Moose::Role)
      1 perl(MooseX::Meta::Role::WarnOnConflict)
      1 perl(strict)
      1 perl(warnings)
FIX: Please add following run-time requires:
     perl(Moose::Meta::Role) - lib/MooseX/Meta/Role/WarnOnConflict.pm:6
     perl(Moose::Meta::Role::Application::ToClass) - lib/MooseX/Role/WarnOnConflict.pm:28

$ rpm -qp --provides perl-MooseX-Role-WarnOnConflict-0.01-1.fc37.noarch.rpm | sort | uniq -c
      1 perl(MooseX::Meta::Role::WarnOnConflict) = 0.01
      1 perl(MooseX::Role::WarnOnConflict) = 0.01
      1 perl-MooseX-Role-WarnOnConflict = 0.01-1.fc37
Binary provides are Ok.

$ rpmlint ./perl-MooseX-Role-WarnOnConflict*
================================ rpmlint session starts ================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s =
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' item.

Resolution:
Approved

Comment 2 Jitka Plesnikova 2022-06-20 17:54:48 UTC

FIX: URL tag
Replace 
http://cpan.metacpan.org/dist/MooseX-Role-WarnOnConflict/
by 
http://metacpan.org/dist/MooseX-Role-WarnOnConflict/

Comment 3 Gwyn Ciesla 2022-06-21 19:47:53 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MooseX-Role-WarnOnConflict

Comment 4 Jitka Plesnikova 2022-06-27 10:25:02 UTC

Built by corsepiu