Bug 2097826

Summary:	Review Request: perl-Types-ReadOnly - Type constraints and coercions for read-only data structures and locked hashes
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Michal Josef Spacek <mspacek>
Status:	ASSIGNED ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mspacek, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	mspacek: fedora-review? mspacek: needinfo-
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ralf Corsepius 2022-06-16 16:15:29 UTC

Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Types-ReadOnly.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Types-ReadOnly-0.003-1.fc37.src.rpm
Description: 
This is a type constraint library for write-restricted references.

This module is built with Type::Tiny, which means that you can use it
with Moo, Mouse, Moose, or none of the above.

Fedora Account System Username: corsepiu

Comment 1 Ralf Corsepius 2022-06-16 16:16:33 UTC

This package is a so far missing, optional BR: of perl-Types-Tiny.

Comment 2 Michal Josef Spacek 2023-05-22 14:03:55 UTC

There are some issues:
* I think that block with '%if !%{defined perl_bootstrap}' is bad. There are runtime dependencies (Type::Tiny, Type::Coercion, Types::Standard, and Type::Library) that are in Type::Tiny dist. We need to remove if/else (bootstrap) and we need to add this kind of bootstrap block to BuildRequire in perl-Type-Tiny (for perl-Types-ReadOnly, is used in tests only).
* Rewrite license to SPDX
* Remove MODULE_COMPAT line

Optional:
* I am for adding comments like "Runtime:" and "Tests:" to BuildRequire list as in other Perl modules

Comment 3 Package Review 2024-05-22 00:45:30 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 4 Michal Josef Spacek 2024-05-22 10:00:23 UTC

@rc040203 What about this ticket?

Comment 5 Ralf Corsepius 2024-05-22 14:44:51 UTC

(In reply to Michal Josef Spacek from comment #4)
> @rc040203 What about this ticket?

It's still valid.

Comment 6 Michal Josef Spacek 2024-11-26 10:32:24 UTC

@rc040203 I send you some comments to fix or to discuss :-)

Comment 7 Ralf Corsepius 2024-12-19 18:27:51 UTC

Updated package:

Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Types-ReadOnly.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Types-ReadOnly-0.003-3.fc42.src.rpm

Comment 8 Fedora Review Service 2024-12-20 00:46:22 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8422676
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2097826-perl-types-readonly/fedora-rawhide-x86_64/08422676-perl-Types-ReadOnly/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.