Bug 2098187

Summary:	Add warning for empty targetattr when creating ACI with RBAC
Product:	Red Hat Enterprise Linux 8	Reporter:	Aleksandr Sharov <asharov>
Component:	ipa	Assignee:	Rob Crittenden <rcritten>
Status:	CLOSED ERRATA	QA Contact:	ipa-qe <ipa-qe>
Severity:	low	Docs Contact:
Priority:	low
Version:	8.6	CC:	frenaud, ftrivino, pasik, rcritten, rjeffman, sumenon, tscherf
Target Milestone:	rc	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ipa-4.9.10-8.module+el8.8.0+17351+9a3fb056	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2108223 2148379 (view as bug list)		Environment:
Last Closed:	2023-05-16 08:28:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2108223, 2148379

Description Aleksandr Sharov 2022-06-17 14:12:11 UTC

Description of problem:
When we create RBAC permission, with CLI or WebUI, we can create permission with empty target attribute list. 

This will act as we didn't permit any attributes to be accessed, so permission without attributes won't do anything.


Version-Release number of selected component (if applicable):
RHEL 8.6
ipa-server-4.9.8-7
389-ds-base-1.4.3.28-6

How reproducible:
always

Expected results:
we should probably add a warning that empty target attributes are not really meaningful. Or just make this mandatory.

Additional info:

Comment 3 Rob Crittenden 2022-06-22 15:13:16 UTC

Linked to upstream issue https://pagure.io/freeipa/issue/9188

Comment 4 Florence Blanc-Renaud 2022-07-15 15:01:34 UTC

Fixed upstream
master:
https://pagure.io/freeipa/c/dc73813b8afccb82b513c49b29de35b7864819b6

Comment 5 Florence Blanc-Renaud 2022-07-15 15:06:38 UTC

Note to QA: the xmlrpc tests already check that the warning is displayed:

ipatests/test_xmlrpc/test_old_permission_plugin.py::test_old_permission
ipatests/test_xmlrpc/test_permission_plugin.py::test_permission_bindtype and ::test_permission_filters
ipatests/test_xmlrpc/test_privilege_plugin.py::test_privilege

Comment 6 Florence Blanc-Renaud 2022-07-16 05:58:41 UTC

Fixed upstream
ipa-4-10:
https://pagure.io/freeipa/c/499f71729b8689d40608d9c99db703eb2c00a934

ipa-4-9:
https://pagure.io/freeipa/c/b31631ad69f72fb42b5091375df8021580f8139a

Comment 13 errata-xmlrpc 2023-05-16 08:28:45 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (idm:client and idm:DL1 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2794