Bug 2098378

Summary:	Review Request: golang-github-delve-liner - pure go line editor
Product:	[Fedora] Fedora	Reporter:	Mark E. Fuller <mark.e.fuller>
Component:	Package Review	Assignee:	Maxwell G <maxwell>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	maxwell, package-review
Target Milestone:	---	Flags:	maxwell: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-06-30 01:18:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mark E. Fuller 2022-06-18 16:27:16 UTC

Spec URL: https://fuller.fedorapeople.org/golang-github-delve-liner.spec
SRPM URL: https://fuller.fedorapeople.org/golang-github-delve-liner-1.2.2-1.fc37.src.rpm
Description: Pure Go line editor with history, inspired by linenoise 
Fedora Account System Username: fuller

Comment 1 Maxwell G 2022-06-20 04:14:11 UTC

I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Add package to Koschei.
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.

Thanks!

Comment 2 Mark E. Fuller 2022-06-20 10:27:49 UTC

Thank you very much

Comment 3 Gwyn Ciesla 2022-06-21 17:27:30 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-delve-liner

Comment 4 Fedora Update System 2022-06-21 22:03:12 UTC

FEDORA-2022-ac3714cff2 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ac3714cff2

Comment 5 Fedora Update System 2022-06-21 22:03:57 UTC

FEDORA-2022-5c13f7cbaa has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5c13f7cbaa

Comment 6 Fedora Update System 2022-06-22 02:02:12 UTC

FEDORA-2022-5c13f7cbaa has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-5c13f7cbaa \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5c13f7cbaa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-06-22 02:21:03 UTC

FEDORA-2022-ac3714cff2 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-ac3714cff2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-ac3714cff2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-06-30 01:18:15 UTC

FEDORA-2022-5c13f7cbaa has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-06-30 02:17:49 UTC

FEDORA-2022-ac3714cff2 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.