Bug 2098589

Summary:	[cephadm] : orch upgrade - redeploying of monitoring daemons fail saying registry login required when registry login was done manually during deployment
Product:	[Red Hat Storage] Red Hat Ceph Storage	Reporter:	Vasishta <vashastr>
Component:	Cephadm	Assignee:	Adam King <adking>
Status:	CLOSED NOTABUG	QA Contact:	Manasa <mgowri>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	5.2	CC:	cephqe-warriors, saraut
Target Milestone:	---
Target Release:	7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-05 15:08:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vasishta 2022-06-20 07:30:42 UTC

Description of problem:
while upgrade redeploying of monitoring daemons fail saying registry login required when registry login was done manually during deployment.

The failure is awkward as podman login was performed initially without which cluster would not have been able to configure.

Version-Release number of selected component (if applicable):
16.2.8-45.el8cp

How reproducible:
Thrice in different envs

Steps to Reproduce:
1. Configure ceph cluster using cephadm.
have two different container registries for monitoring stack daemons and ceph.
Monitoring stack image registry needs to have authentication and do podman login manually using `podman login <registry>`
2. Upgrade cluster to another build using ceph orch upgrade.

Actual results:
Upgrade fails saying prometheus daemon redeploy failed due to invalid credentials .

Expected results:
registry login must not be asked again as it was performed during initial cluster deployment and when there had not been any change in the credentials.


Additional info:
upgrade failure was not repeated after using cephadm registry-login on that particular node.