Bug 209948
Summary: | Review Request: telepathy-feed - Galago feed for Telepathy | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-10-13 14:37:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Brian Pepple
2006-10-08 18:06:32 UTC
I will review this later. Well, W: galago-filesystem no-url-tag (for src.rpm) W: galago-filesystem no-%build-section (for src.rpm) The formar warning can be ignored. no-%build-section warning says: ------------------------------------------------------------------------------ The spec file does not contain a %build section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality, such as injection of automatic -debuginfo subpackages. Add the section, even if empty. ------------------------------------------------------------------------------ It seems that adding %build section is preferable even if it seems nonsense. ------------------------------------------------------------------------------ These packages (telepathy-feed & galago-filesystem) are APPROVED by me. Thanks for the review. |