Bug 209948

Summary: Review Request: telepathy-feed - Galago feed for Telepathy
Product: [Fedora] Fedora Reporter: Brian Pepple <bdpepple>
Component: Package ReviewAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-10-13 14:37:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Brian Pepple 2006-10-08 18:06:32 UTC
Spec URL: http://piedmont.homelinux.org/fedora/telepathy/telepathy-feed.spec
SRPM URL: http://piedmont.homelinux.org/fedora/telepathy/telepathy-feed-0.13-1.src.rpm
Description: A Galago feed for Telepathy

Note: This will only build on Rawhide currently until libgalago is updated in FC5.  Also, this package will need to require a galago-filesystem package since multiple packages now use '%{_libdir}/galago/'

Spec URL: http://piedmont.homelinux.org/fedora/telepathy/galago-filesystem.spec
SRPM URL: http://piedmont.homelinux.org/fedora/telepathy/galago-filesystem-0.0.1-1.src.rpm
Description: Galago filesystem layout

Comment 1 Mamoru TASAKA 2006-10-11 08:26:10 UTC
I will review this later.

Comment 2 Mamoru TASAKA 2006-10-11 14:13:33 UTC
Well, 

W: galago-filesystem no-url-tag (for src.rpm)
W: galago-filesystem no-%build-section (for src.rpm)

The formar warning can be ignored.
no-%build-section warning says:
------------------------------------------------------------------------------
The spec file does not contain a %build section.  Even if some packages
don't directly need it, section markers may be overridden in rpm's
configuration to provide additional "under the hood" functionality, such as
injection of automatic -debuginfo subpackages.  Add the section, even if
empty.
------------------------------------------------------------------------------
It seems that adding %build section is preferable even if
it seems nonsense.


------------------------------------------------------------------------------
 These packages (telepathy-feed & galago-filesystem) are
 APPROVED by me.

Comment 3 Brian Pepple 2006-10-13 14:37:30 UTC
Thanks for the review.