Bug 2099613

Summary: Add definition of _find_debuginfo_extra_opts to macros
Product: Red Hat Enterprise Linux 9 Reporter: Nick Clifton <nickc>
Component: redhat-rpm-configAssignee: Nick Clifton <nickc>
Status: CLOSED ERRATA QA Contact: Martin Cermak <mcermak>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.1CC: codonell, fberat, fweimer, mcermak, pmatilai
Target Milestone: rcKeywords: Bugfix, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: redhat-rpm-config-196-1.el9 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-15 10:27:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Define _find_debuginfo_extra_opts none

Description Nick Clifton 2022-06-21 10:35:19 UTC
Created attachment 1891556 [details]
Define _find_debuginfo_extra_opts

Please can commit e7f4716 to the Fedora rawhide version of redhat-rpm-config be applied to the RHEL-9 version.  (Commit attached).

This commit adds a definition of the _find_debuginfo_extra_opts variable with the text necessary to cause the find-debuginfo.sh script to move any notes created by the annobin plugin out of the executable and into its associated debuginfo file.
This reduces the size of compiled executables, at the cost of larger debuginfo files.

The change will only work once the _find_debuginfo_extra_opts variable is added to the list of variables passed to the find-debuginfo.sh script.  This is handled by the rpm package.  Hence a separate BZ will be created for that change.

Comment 1 Panu Matilainen 2022-06-22 08:38:37 UTC
See my feedback in https://src.fedoraproject.org/rpms/rpm/pull-request/25 

On a related note, it would be technically possibly to just override %__debug_install_post in redhat-rpm-config so toolchain stuff can all be managed from redhat-rpm-config side. It's been that way in the past but whether it was for good reasons I don't know. I'm not particularly promoting this, but it's an option.

Comment 2 Nick Clifton 2022-06-22 09:48:41 UTC
(In reply to Panu Matilainen from comment #1)
> See my feedback in https://src.fedoraproject.org/rpms/rpm/pull-request/25 

Thanks!  I have updated to the PR to rename the variable to _find_debuginfo_vendor_opts
If that is accepted then I would of course wish to use the same name to fulfill this BZ.


> On a related note, it would be technically possibly to just override
> %__debug_install_post in redhat-rpm-config so toolchain stuff can all be
> managed from redhat-rpm-config side. It's been that way in the past but
> whether it was for good reasons I don't know. I'm not particularly promoting
> this, but it's an option.

An idea, but I think that it might be confusing for package maintainers.  Still if I
cannot get my updates to the rpm package approved then I may have to choose this route
instead.

Thanks for the suggestion.

Comment 4 Nick Clifton 2022-06-27 14:50:02 UTC
Fixed in redhat-rpm-config-196-1.el9

Note - this update will not have any active effect yet, because the corresponding change to the rpm package (BZ 2099617) has not gone in yet.  It may be possible to see the _find_debuginfo_vendor_opts variable being set in the build.log of a random package however.  I am not sure if these logs show all of the macro variables being set...

Comment 8 errata-xmlrpc 2022-11-15 10:27:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (redhat-rpm-config bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8149