Bug 2099789

Summary:	Review Request: pepc - Power, Energy, and Performance configuration tool
Product:	[Fedora] Fedora	Reporter:	Ali Erdinc Koroglu <ali.erdinc.koroglu>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-06 06:40:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2099771

Description Ali Erdinc Koroglu 2022-06-21 17:16:05 UTC

SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/intel-fedora/fedora-rawhide-x86_64/04552292-pepc/pepc.spec
SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/intel-fedora/fedora-rawhide-x86_64/04552292-pepc/pepc-1.3.8-1.fc37.src.rpm

Description:
Power, Energy, and Performance configuration tool

Note:
Required for https://bugzilla.redhat.com/show_bug.cgi?id=2099771

Comment 1 Zbigniew Jędrzejewski-Szmek 2022-07-05 10:25:43 UTC

"%pytest" → "%pytest -v"

rpmautospec?

Maybe add "Recommends:kmod" for /sbin/modprobe.

"Requires: python3-pepc" → "Requires: python3-pepc = %{version}-%{relese}"
(For your own sanity: you want to avoid the situation where there's some dependency
issue and users and up with mismatched versions of the subpackages.)

+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly (SPDX)
+ latest version: 1.3.9 was released a few days ago, but it seems that it just added a spec file for Fedora.
  So that's fine too.
+ BR/R look fine
+ builds and installs OK, seems to work OK

rpmlint:
python3-pepc.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/pepclibs/helperlibs/EmulProcessManager.py 644 /usr/bin/env python3
python3-pepc.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/pepctool/_Pepc.py 644 /usr/bin/python3
python3-pepc.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/pepctool/_PepcASPM.py 644 /usr/bin/python3
python3-pepc.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/pepctool/_PepcCPUHotplug.py 644 /usr/bin/python3
python3-pepc.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/pepctool/_PepcCStates.py 644 /usr/bin/python3
python3-pepc.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/pepctool/_PepcCommon.py 644 /usr/bin/python3
python3-pepc.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/pepctool/_PepcPStates.py 644 /usr/bin/python3
→ Meh :]
python3-pepc.noarch: W: no-documentation
pepc.noarch: W: invalid-license BSD-3-Clause
pepc.src: W: invalid-license BSD-3-Clause
python3-pepc.noarch: W: invalid-license BSD-3-Clause
→ rpmlint doesn't grok SPDX.

Package is APPROVED.

Comment 2 Ali Erdinc Koroglu 2022-07-05 14:23:29 UTC

Hi there, I changed the spec file as you recommended.

SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/intel-fedora/fedora-rawhide-x86_64/04597774-pepc/pepc.spec
SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/intel-fedora/fedora-rawhide-x86_64/04597774-pepc/pepc-1.3.9-1.fc37.src.rpm

Thank you.

Comment 3 Zbigniew Jędrzejewski-Szmek 2022-07-05 15:36:46 UTC

Please also do 'fedpkg request-repo'.

Comment 4 Ali Erdinc Koroglu 2022-07-05 17:18:48 UTC

Sure, thank you.

Comment 5 Gwyn Ciesla 2022-07-05 17:58:17 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/pepc

Comment 6 Ali Erdinc Koroglu 2022-07-06 06:40:26 UTC

Merged into rawhide, thank you all.